Changeset 29814 in webkit

Timestamp:

Jan 26, 2008 8:10:18 PM (16 years ago)

Author:

mrowe@apple.com

Message:

Fix leaks seen after loading <​http://www.funnyordie.com/videos/d70b5a11cb>.

Reviewed by Darin Adler.

• Misc/WebNSDataExtras.m:

(-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
to the new CFString so that they will be freed when no longer needed.

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Misc/WebNSDataExtras.m (modified) (1 diff)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2008-01-26  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
+
+        * Misc/WebNSDataExtras.m:
+        (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
+        to the new CFString so that they will be freed when no longer needed.
+
 2008-01-26  Greg Bolsinga  <bolsinga@apple.com>
 

trunk/WebKit/mac/Misc/WebNSDataExtras.m

@@ -93 +93 @@
     if (somethingChanged) {
         if (useUniCharPtr) {
-            result = (NSString *)CFMakeCollectable(CFStringCreateWithCharacters(NULL, uniCharPtr, len));
+            result = (NSString *)CFMakeCollectable(CFStringCreateWithCharactersNoCopy(NULL, uniCharPtr, len, NULL));
         } 
         else {
-            result = (NSString *)CFMakeCollectable(CFStringCreateWithCString(NULL, charPtr, kCFStringEncodingISOLatin1));
+            result = (NSString *)CFMakeCollectable(CFStringCreateWithCStringNoCopy(NULL, charPtr, kCFStringEncodingISOLatin1, NULL));
         }
     }