Changeset 29953 in webkit


Ignore:
Timestamp:
Feb 3, 2008 3:55:42 PM (16 years ago)
Author:
eric@webkit.org
Message:

Reviewed by darin.

Acid3 expects textNode.localName === null
​http://bugs.webkit.org/show_bug.cgi?id=17060

Test: fast/dom/Node/initial-values.html

  • dom/Comment.cpp: remove localName implementation
  • dom/Comment.h:
  • dom/Node.cpp: return nullAtom instead of emptyAtom
  • dom/Text.cpp: remove localName implementation
  • dom/Text.h:
Location:
trunk
Files:
6 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r29952 r29953  
     12008-02-03  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by darin.
     4       
     5        Acid3 expects textNode.localName === null
     6        http://bugs.webkit.org/show_bug.cgi?id=17060
     7        Add test to verify that initial values after node creation
     8        agree with the W3C DOM Level 2/3 specs.
     9       
     10        We intentionally "fail" a few of these tests.
     11        http://bugs.webkit.org/show_bug.cgi?id=17167 covers those "failures"
     12
     13        * fast/dom/Node/initial-values.html: Added.
     14        * fast/dom/Node/initial-values-expected.txt: Added.
     15        * fast/dom/Node/resources/TEMPLATE.html: Added.
     16        * fast/dom/Node/resources/initial-values.js: Added.
     17
    1182008-02-03  Eric Seidel  <eric@webkit.org>
    219

  • trunk/WebCore/ChangeLog

    r29952 r29953  
     12008-02-03  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by darin.
     4
     5        Acid3 expects textNode.localName === null
     6        http://bugs.webkit.org/show_bug.cgi?id=17060
     7
     8        Test: fast/dom/Node/initial-values.html
     9
     10        * dom/Comment.cpp: remove localName implementation
     11        * dom/Comment.h:
     12        * dom/Node.cpp: return nullAtom instead of emptyAtom
     13        * dom/Text.cpp: remove localName implementation
     14        * dom/Text.h:
     15
    1162008-02-03  Eric Seidel  <eric@webkit.org>
    217

  • trunk/WebCore/dom/Comment.cpp

    r29317 r29953  
    4343}
    4444
    45 const AtomicString& Comment::localName() const
    46 {
    47     return commentAtom;
    48 }
    49 
    5045String Comment::nodeName() const
    5146{

  • trunk/WebCore/dom/Comment.h

    r27690 r29953  
    3838
    3939    // DOM methods overridden from  parent classes
    40     const AtomicString& localName() const;
    4140    virtual String nodeName() const;
    4241    virtual NodeType nodeType() const;

  • trunk/WebCore/dom/Node.cpp

    r29481 r29953  
    336336const AtomicString& Node::localName() const
    337337{
    338     return emptyAtom;
     338    return nullAtom;
    339339}
    340340

  • trunk/WebCore/dom/Text.cpp

    r29926 r29953  
    8888}
    8989
    90 const AtomicString& Text::localName() const
    91 {
    92     return textAtom;
    93 }
    94 
    9590String Text::nodeName() const
    9691{

  • trunk/WebCore/dom/Text.h

    r29926 r29953  
    4242    // DOM methods overridden from parent classes
    4343
    44     virtual const AtomicString& localName() const;
    4544    virtual String nodeName() const;
    4645    virtual NodeType nodeType() const;
Note: See TracChangeset for help on using the changeset viewer.