Changeset 30028 in webkit


Ignore:
Timestamp:
Feb 5, 2008 3:09:47 PM (16 years ago)
Author:
Nikolas Zimmermann
Message:

Reviewed by Oliver.
Fix dynamic updates of <circle> element's properties.

Added tests: svg/dynamic-updates/SVGCircleElement*

Location:
trunk
Files:
30 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r30021 r30028  
     12008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
     2
     3        Reviewed by Oliver.
     4
     5        Next round of dynamic update tests, for SVGCircleElement.
     6
     7        * svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
     8        * svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
     9        * svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.txt: Added.
     10        * svg/dynamic-updates/SVGCircleElement-dom-cx-attr.html: Added.
     11        * svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum: Added.
     12        * svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
     13        * svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.txt: Added.
     14        * svg/dynamic-updates/SVGCircleElement-dom-cy-attr.html: Added.
     15        * svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum: Added.
     16        * svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
     17        * svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.txt: Added.
     18        * svg/dynamic-updates/SVGCircleElement-dom-r-attr.html: Added.
     19        * svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum: Added.
     20        * svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
     21        * svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.txt: Added.
     22        * svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop.html: Added.
     23        * svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum: Added.
     24        * svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
     25        * svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.txt: Added.
     26        * svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop.html: Added.
     27        * svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum: Added.
     28        * svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
     29        * svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.txt: Added.
     30        * svg/dynamic-updates/SVGCircleElement-svgdom-r-prop.html: Added.
     31        * svg/dynamic-updates/resources/SVGCircleElement-dom-cx-attr.js: Added.
     32        * svg/dynamic-updates/resources/SVGCircleElement-dom-cy-attr.js: Added.
     33        * svg/dynamic-updates/resources/SVGCircleElement-dom-r-attr.js: Added.
     34        * svg/dynamic-updates/resources/SVGCircleElement-svgdom-cx-prop.js: Added.
     35        * svg/dynamic-updates/resources/SVGCircleElement-svgdom-cy-prop.js: Added.
     36        * svg/dynamic-updates/resources/SVGCircleElement-svgdom-r-prop.js: Added.
     37        * svg/dynamic-updates/resources/SVGTestCase.js:
     38
    1392008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
    240

  • trunk/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js

    r30021 r30028  
    3232}
    3333
    34 function testFinished() {
     34function waitForClickEvent(obj) {
    3535    if (window.layoutTestController)
    36         layoutTestController.notifyDone();
     36        obj.setAttribute("onclick", "layoutTestController.notifyDone()");
    3737}

  • trunk/WebCore/ChangeLog

    r30027 r30028  
     12008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
     2
     3        Reviewed by Oliver.
     4
     5        Fix dynamic updates of <circle> element's properties.
     6
     7        Added tests: svg/dynamic-updates/SVGCircleElement*
     8
     9        * svg/SVGCircleElement.cpp:
     10        (WebCore::SVGCircleElement::svgAttributeChanged): Mixed up cxAttr/xAttr etc.
     11        * svg/SVGCircleElement.h:
     12
    1132008-02-05  Rodney Dawes  <dobey@wayofthemonkey.com>
    214

  • trunk/WebCore/svg/SVGCircleElement.cpp

    r29951 r30028  
    7979        return;
    8080
    81     if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr ||
    82         attrName == SVGNames::widthAttr || attrName == SVGNames::heightAttr ||
     81    if (attrName == SVGNames::cxAttr || attrName == SVGNames::cyAttr ||
     82        attrName == SVGNames::rAttr ||
    8383        SVGTests::isKnownAttribute(attrName) ||
    8484        SVGLangSpace::isKnownAttribute(attrName) ||

  • trunk/WebCore/svg/SVGCircleElement.h

    r29951 r30028  
    3030#include "SVGTests.h"
    3131
    32 namespace WebCore
    33 {
     32namespace WebCore {
     33
    3434    class SVGCircleElement : public SVGStyledTransformableElement,
    3535                             public SVGTests,
    3636                             public SVGLangSpace,
    37                              public SVGExternalResourcesRequired
    38     {
     37                             public SVGExternalResourcesRequired {
    3938    public:
    4039        SVGCircleElement(const QualifiedName&, Document*);
Note: See TracChangeset for help on using the changeset viewer.