Changeset 30044 in webkit


Ignore:
Timestamp:
Feb 6, 2008 11:26:14 AM (16 years ago)
Author:
hyatt@apple.com
Message:

Fix for bug 16799, object elements should return absolute URLs from .data.

Reviewed by Mark Rowe

  • dom/Document.cpp: (WebCore::Document::completeURL):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::href):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::data):
Location:
trunk/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r30043 r30044  
     12008-02-06  David Hyatt  <hyatt@apple.com>
     2
     3        Fix for bug 16799, object elements should return absolute URLs from .data.
     4
     5        Reviewed by Mark Rowe
     6
     7        * dom/Document.cpp:
     8        (WebCore::Document::completeURL):
     9        * html/HTMLAnchorElement.cpp:
     10        (WebCore::HTMLAnchorElement::href):
     11        * html/HTMLObjectElement.cpp:
     12        (WebCore::HTMLObjectElement::data):
     13
    1142008-02-05  Antti Koivisto  <antti@apple.com>
    215
  • trunk/WebCore/dom/Document.cpp

    r30007 r30044  
    28172817{
    28182818    // FIXME: This always returns null when passed a null URL, unlike the DeprecatedString function above.
     2819    // Code relies on this behavior, namely the href property of <a> and the data property of <object>.
    28192820    if (url.isNull())
    28202821        return url;
  • trunk/WebCore/html/HTMLAnchorElement.cpp

    r25754 r30044  
    331331String HTMLAnchorElement::href() const
    332332{
    333     String href = getAttribute(hrefAttr);
    334     if (href.isNull())
    335         return href;
    336     return document()->completeURL(href);
     333    return document()->completeURL(getAttribute(hrefAttr));
    337334}
    338335
  • trunk/WebCore/html/HTMLObjectElement.cpp

    r29918 r30044  
    392392String HTMLObjectElement::data() const
    393393{
    394     return getAttribute(dataAttr);
     394    return document()->completeURL(getAttribute(dataAttr));
    395395}
    396396
Note: See TracChangeset for help on using the changeset viewer.