Changeset 30353 in webkit


Ignore:
Timestamp:
Feb 17, 2008 4:12:54 AM (16 years ago)
Author:
mrowe@apple.com
Message:

2008-02-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Mark Rowe.

Fix a crash introduced in changeset #29985 by moving the dereference to after
the null check.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
Location:
trunk/WebKit/gtk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/gtk/ChangeLog

    r30267 r30353  
     12008-02-17  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
     2
     3        Reviewed by Mark Rowe.
     4
     5        Fix a crash introduced in changeset #29985 by moving the dereference to after
     6        the null check.
     7
     8        * webkit/webkitwebhistoryitem.cpp:
     9        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
     10
    1112008-02-15  Alp Toker  <alp@atoker.com>
    212
  • trunk/WebKit/gtk/webkit/webkitwebhistoryitem.cpp

    r30031 r30353  
    124124{
    125125    WebKitWebHistoryItem* webHistoryItem = kit(item);
    126     WebKitWebHistoryItemPrivate* priv = webHistoryItem->priv;
    127126
    128127    if (!webHistoryItem) {
    129128        webHistoryItem = WEBKIT_WEB_HISTORY_ITEM(g_object_new(WEBKIT_TYPE_WEB_HISTORY_ITEM, NULL));
     129        WebKitWebHistoryItemPrivate* priv = webHistoryItem->priv;
    130130        priv->historyItem = item;
    131131        webkit_history_item_add(webHistoryItem, priv->historyItem);
Note: See TracChangeset for help on using the changeset viewer.