Changeset 30359 in webkit

Timestamp:

Feb 17, 2008 3:53:27 PM (16 years ago)

Author:

alp@webkit.org

Message:

2008-02-17 Alp Toker <​alp@atoker.com>

Reviewed by Sam Weinig.

Fix for change made in r30355. Issue noticed by İsmail Dönmez.

Verify SSL certs by default, but allow checks to be disabled with an
environment variable (WEBKIT_IGNORE_SSL_ERRORS) for now.

• platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startJob):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/curl/ResourceHandleManager.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-02-17  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Sam Weinig.
+
+        Fix for change made in r30355. Issue noticed by İsmail Dönmez.
+
+        Verify SSL certs by default, but allow checks to be disabled with an
+        environment variable (WEBKIT_IGNORE_SSL_ERRORS) for now.
+
+        * platform/network/curl/ResourceHandleManager.cpp:
+        (WebCore::ResourceHandleManager::startJob):
+
 2008-02-17  Bin Chen  <binary.chen@gmail.com>
 

trunk/WebCore/platform/network/curl/ResourceHandleManager.cpp

@@ -55 +55 @@
 const int maxRunningJobs = 5;
 
+static const bool ignoreSSLErrors = getenv("WEBKIT_IGNORE_SSL_ERRORS");
+
 ResourceHandleManager::ResourceHandleManager()
     : m_downloadTimer(this, &ResourceHandleManager::downloadTimerCallback)
@@ -565 +567 @@
     // FIXME: Enable SSL verification when we have a way of shipping certs
     // and/or reporting SSL errors to the user.
-    curl_easy_setopt(d->m_handle, CURLOPT_SSL_VERIFYPEER, false);
+    if (ignoreSSLErrors)
+        curl_easy_setopt(d->m_handle, CURLOPT_SSL_VERIFYPEER, false);
     // enable gzip and deflate through Accept-Encoding:
     curl_easy_setopt(d->m_handle, CURLOPT_ENCODING, "");