Changeset 30458 in webkit


Ignore:
Timestamp:
Feb 21, 2008 10:09:48 AM (16 years ago)
Author:
ggaren@apple.com
Message:

WebCore:

Reviewed by David Harrison.


Fixed <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget

Test: fast/dom/script-element-without-frame-crash.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added back a NULL check that was accidentally removed in r30325.

LayoutTests:

Reviewed by David Harrison.


Test for <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget

  • fast/dom/script-element-without-frame-crash-expected.txt: Added.
  • fast/dom/script-element-without-frame-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r30456 r30458  
     12008-02-21  Geoffrey Garen  <ggaren@apple.com>
     2
     3        Reviewed by David Harrison.
     4       
     5        Test for <rdar://problem/5756125> REGRESSION: A crash occurs at
     6        WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget
     7
     8        * fast/dom/script-element-without-frame-crash-expected.txt: Added.
     9        * fast/dom/script-element-without-frame-crash.html: Added.
     10
    1112008-02-20  Sam Weinig  <sam@webkit.org>
    212

  • trunk/WebCore/ChangeLog

    r30457 r30458  
     12008-02-21  Geoffrey Garen  <ggaren@apple.com>
     2
     3        Reviewed by David Harrison.
     4       
     5        Fixed <rdar://problem/5756125> REGRESSION: A crash occurs at
     6        WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget
     7
     8        Test: fast/dom/script-element-without-frame-crash.html
     9
     10        * html/HTMLTokenizer.cpp:
     11        (WebCore::HTMLTokenizer::parseTag): Added back a NULL check that was
     12        accidentally removed in r30325.
     13
    1142008-02-21  Rodney Dawes  <dobey@wayofthemonkey.com>
    215

  • trunk/WebCore/html/HTMLTokenizer.cpp

    r30455 r30458  
    14461446                scriptSrcCharset = String();
    14471447                if (currToken.attrs && !m_fragment) {
    1448                     if (m_doc->frame()->scriptProxy()->isEnabled()) {
     1448                    if (m_doc->frame() && m_doc->frame()->scriptProxy()->isEnabled()) {
    14491449                        if ((a = currToken.attrs->getAttributeItem(srcAttr)))
    14501450                            scriptSrc = m_doc->completeURL(parseURL(a->value())).string();
Note: See TracChangeset for help on using the changeset viewer.