Changeset 31084 in webkit
- Timestamp:
- Mar 16, 2008 1:53:39 PM (16 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r31083 r31084 1 2008-03-16 Antti Koivisto <antti@apple.com> 2 3 Reviewed by Darin. 4 5 Test for http://bugs.webkit.org/show_bug.cgi?id=17862 6 REGRESSION (r31038): Reproducible crash under DocLoader::checkForReload() at marware.com 7 8 * http/tests/misc/resources/uncacheable-script.cgi: Added. 9 * http/tests/misc/uncacheable-script-repeated-expected.txt: Added. 10 * http/tests/misc/uncacheable-script-repeated.html: Added. 11 1 12 2008-03-16 Yuzhu Shen <yuzhu.shen@gmail.com> 2 13 -
trunk/WebCore/ChangeLog
r31083 r31084 1 2008-03-16 Antti Koivisto <antti@apple.com> 2 3 Reviewed by Darin. 4 5 Fix http://bugs.webkit.org/show_bug.cgi?id=17862 6 REGRESSION (r31038): Reproducible crash under DocLoader::checkForReload() at marware.com 7 8 This was a memory smasher introduced by the preloading patch. 9 If a script resource was marked uncacheable, early deletion of the 10 Request object would cause deletion of the CachedResource too if 11 it was referred more than once in a single document. 12 13 Test: http/tests/misc/uncacheable-script-repeated.html 14 15 * loader/loader.cpp: 16 (WebCore::Loader::Host::servePendingRequests): 17 (WebCore::Loader::Host::didFinishLoading): 18 1 19 2008-03-16 Yuzhu Shen <yuzhu.shen@gmail.com> 2 20 -
trunk/WebCore/loader/loader.cpp
r31041 r31084 236 236 request->cachedResource()->setRequestedFromNetworkingLayer(); 237 237 #if REQUEST_DEBUG 238 printf("HOST %s COUNT %d LOADING %s\n", resourceRequest.url().host().latin1().data(), m_requestsLoading.size(), req ->cachedResource()->url().latin1().data());238 printf("HOST %s COUNT %d LOADING %s\n", resourceRequest.url().host().latin1().data(), m_requestsLoading.size(), request->cachedResource()->url().latin1().data()); 239 239 #endif 240 240 } else { … … 261 261 262 262 CachedResource* resource = request->cachedResource(); 263 delete request;264 263 265 264 // If we got a 4xx response, we're pretending to have received a network … … 270 269 resource->finish(); 271 270 } 271 272 delete request; 272 273 273 274 docLoader->setLoadInProgress(false);
Note: See TracChangeset
for help on using the changeset viewer.