Changeset 31821 in webkit

Timestamp:

Apr 11, 2008 2:18:05 PM (16 years ago)

Author:

mrowe@apple.com

Message:

Fix ​https://bugs.webkit.org/show_bug.cgi?id=18430
Bug 18430: SIGSEGV on amd64 when built with gcc 4.3

GCC 4.3 generates bad code in some instances when working with our HashTables
as some of the HashTable code violates the strict aliasing requirements. Since
GCC 4.2 this code has generated warnings when -fstrict-aliasing is enabled. Until
the code can be fixed to be safe with strict aliasing enabled, we will disable
strict aliasing.

Rubber-stamped by Anders Carlsson.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• GNUmakefile.am (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2008-04-11  Mark Rowe  <mrowe@apple.com>
+
+        Rubber-stamped by Anders Carlsson.
+
+        Fix https://bugs.webkit.org/show_bug.cgi?id=18430
+        Bug 18430: SIGSEGV on amd64 when built with gcc 4.3
+
+        GCC 4.3 generates bad code in some instances when working with our HashTables
+        as some of the HashTable code violates the strict aliasing requirements.  Since
+        GCC 4.2 this code has generated warnings when -fstrict-aliasing is enabled. Until
+        the code can be fixed to be safe with strict aliasing enabled, we will disable
+        strict aliasing.
+
+        * GNUmakefile.am:
+
 2008-03-12  Michael Emmel  <mike.emmel@gmail.com>
 

trunk/GNUmakefile.am

@@ -117 +117 @@
         $(GLOBALDEPS_CFLAGS) \
         $(UNICODE_CFLAGS) \
-        -fstrict-aliasing
+        -fno-strict-aliasing
 
 libJavaScriptCore_la_CFLAGS = \
@@ -123 +123 @@
         $(GLOBALDEPS_CFLAGS) \
         $(UNICODE_CFLAGS) \
-        -fstrict-aliasing
+        -fno-strict-aliasing
 
 libJavaScriptCore_la_CPPFLAGS = \