Changeset 32340 in webkit

Timestamp:

Apr 21, 2008 1:15:59 PM (16 years ago)

Author:

Adam Roben

Message:

Fix Bug 18615: Crash in PluginPackage::hash

<​https://bugs.webkit.org/show_bug.cgi?id=18615>

Reviewed by Anders Carlsson.

• plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::refresh): Don't pass a null PluginPackage* to add().

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/PluginDatabase.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-04-21  Adam Roben  <aroben@apple.com>
+
+        Fix Bug 18615: Crash in PluginPackage::hash
+
+        <https://bugs.webkit.org/show_bug.cgi?id=18615>
+
+        Reviewed by Anders Carlsson.
+
+        * plugins/PluginDatabase.cpp:
+        (WebCore::PluginDatabase::refresh): Don't pass a null PluginPackage*
+        to add().
+
 2008-04-21  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/plugins/PluginDatabase.cpp

@@ -107 +107 @@
         }
 
-        if (add(PluginPackage::createPackage(*it, lastModified)))
+        RefPtr<PluginPackage> package = PluginPackage::createPackage(*it, lastModified);
+        if (package && add(package.release()))
             pluginSetChanged = true;
     }
@@ -247 +248 @@
 bool PluginDatabase::add(PassRefPtr<PluginPackage> prpPackage)
 {
+    ASSERT_ARG(prpPackage, prpPackage);
+
     RefPtr<PluginPackage> package = prpPackage;