Changeset 32610 in webkit

Timestamp:

Apr 27, 2008 11:49:52 PM (16 years ago)

Author:

rwlbuis@webkit.org

Message:

Reviewed by Adele.

​https://bugs.webkit.org/show_bug.cgi?id=18652
onchange events don't seem to fire for input[type=range] controls.

Fire changeEvent when dragging the slider.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/slider-onchange-event-expected.txt (added)
• LayoutTests/fast/forms/slider-onchange-event.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderSlider.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-04-27  Rob Buis  <buis@kde.org>
+
+        Reviewed by Adele.
+
+        Testcase for:
+        https://bugs.webkit.org/show_bug.cgi?id=18652
+        onchange events don't seem to fire for input[type=range] controls.
+
+        * fast/forms/slider-onchange-event-expected.txt: Added.
+        * fast/forms/slider-onchange-event.html: Added.
+
 2008-04-27  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-04-27  Rob Buis  <buis@kde.org>
+
+        Reviewed by Adele.
+
+        https://bugs.webkit.org/show_bug.cgi?id=18652
+        onchange events don't seem to fire for input[type=range] controls.
+
+        Fire changeEvent when dragging the slider.
+
+        Test: fast/forms/slider-onchange-event.html
+
+        * rendering/RenderSlider.cpp:
+        (WebCore::RenderSlider::valueChanged):
+
 2008-04-25  Darin Adler  <darin@apple.com>
 

trunk/WebCore/rendering/RenderSlider.cpp

@@ -350 +350 @@
 {
     setValueForPosition(currentPosition());
+    static_cast<HTMLInputElement*>(node())->onChange();
 }