Changeset 33023 in webkit


Ignore:
Timestamp:
May 9, 2008 9:44:05 PM (16 years ago)
Author:
weinig@apple.com
Message:

WebCore:

2008-05-09 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18958
NULL pointer dereference in NamedAttrMap::setNamedItem

Test: fast/dom/NamedNodeMap-setNamedItem-crash.html

  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): Null check the argument.

LayoutTests:

2008-05-09 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=18958
NULL pointer dereference in NamedAttrMap::setNamedItem

  • fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Added.
  • fast/dom/NamedNodeMap-setNamedItem-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r33006 r33023  
     12008-05-09  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Mark Rowe.
     4
     5        Test for https://bugs.webkit.org/show_bug.cgi?id=18958
     6        NULL pointer dereference in NamedAttrMap::setNamedItem
     7
     8        * fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Added.
     9        * fast/dom/NamedNodeMap-setNamedItem-crash.html: Added.
     10
    1112008-05-09  Adam Barth  <abarth-webkit@adambarth.com>
    212

  • trunk/WebCore/ChangeLog

    r33010 r33023  
     12008-05-09  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Mark Rowe.
     4
     5        Fix for https://bugs.webkit.org/show_bug.cgi?id=18958
     6        NULL pointer dereference in NamedAttrMap::setNamedItem
     7
     8        Test: fast/dom/NamedNodeMap-setNamedItem-crash.html
     9
     10        * dom/NamedAttrMap.cpp:
     11        (WebCore::NamedAttrMap::setNamedItem): Null check the argument.
     12
    1132008-05-09  Kevin McCullough  <kmccullough@apple.com>
    214

  • trunk/WebCore/dom/NamedAttrMap.cpp

    r31757 r33023  
    9393PassRefPtr<Node> NamedAttrMap::setNamedItem(Node* arg, ExceptionCode& ec)
    9494{
    95     if (!m_element) {
     95    if (!m_element || !arg) {
    9696        ec = NOT_FOUND_ERR;
    9797        return 0;
Note: See TracChangeset for help on using the changeset viewer.