Changeset 33458 in webkit

Timestamp:

May 14, 2008 3:07:56 PM (16 years ago)

Author:

hyatt@apple.com

Message:

2008-05-14 David Hyatt <​hyatt@apple.com>

Fix for bug ​https://bugs.webkit.org/show_bug.cgi?id=16130.

Opacity, transforms, reflections and masks should not honor z-index unless the element is also
positioned. Always reset to auto if the element is not positioned (and then the following code will
adjust auto to 0 as needed).

Reviewed by Dan Bernstein

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):

Location:

trunk

Files:

• LayoutTests/fast/layers/opacity-stacking.html (added)
• LayoutTests/platform/mac/fast/layers/opacity-stacking-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSStyleSelector.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-05-14  David Hyatt  <hyatt@apple.com>
+
+        Fix for bug https://bugs.webkit.org/show_bug.cgi?id=16130.
+
+        Opacity, transforms, reflections and masks should not honor z-index unless the element is also
+        positioned.  Always reset to auto if the element is not positioned (and then the following code will
+        adjust auto to 0 as needed).
+
+        Reviewed by Dan Bernstein
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::adjustRenderStyle):
+
 2008-05-14  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/css/CSSStyleSelector.cpp

@@ -1182 +1182 @@
     }
 
-    // Make sure our z-index value is only applied if the object is positioned,
-    // relatively positioned, transparent, or has a transform/mask/reflection.
-    if (style->position() == StaticPosition && style->opacity() == 1.0f && !style->hasTransform() && !style->hasMask() && !style->boxReflect())
+    // Make sure our z-index value is only applied if the object is positioned.
+    if (style->position() == StaticPosition)
         style->setHasAutoZIndex();