Changeset 33459 in webkit


Ignore:
Timestamp:
May 14, 2008 3:20:02 PM (16 years ago)
Author:
Adam Roben
Message:

Fix Bug 18767: Inspector is currently pretty much useless on Windows

<https://bugs.webkit.org/show_bug.cgi?id=18767>

Reviewed by Tim Hatcher.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::highlight): Only move the highlight behind the Inspector window when first creating the highlight, not every time we update it.
Location:
trunk/WebKit/win
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/win/ChangeLog

    r33394 r33459  
     12008-05-14  Adam Roben  <aroben@apple.com>
     2
     3        Fix Bug 18767: Inspector is currently pretty much useless on Windows
     4
     5        <https://bugs.webkit.org/show_bug.cgi?id=18767>
     6
     7        Reviewed by Tim Hatcher.
     8
     9        * WebCoreSupport/WebInspectorClient.cpp:
     10        (WebInspectorClient::highlight): Only move the highlight behind the
     11        Inspector window when first creating the highlight, not every time we
     12        update it.
     13
    1142008-05-13  Adam Roben  <aroben@apple.com>
    215
  • trunk/WebKit/win/WebCoreSupport/WebInspectorClient.cpp

    r32882 r33459  
    270270void WebInspectorClient::highlight(Node*)
    271271{
    272     if (!m_highlight)
     272    bool creatingHighlight = !m_highlight;
     273
     274    if (creatingHighlight)
    273275        m_highlight.set(new WebNodeHighlight(m_inspectedWebView));
    274276
     
    278280        m_highlight->setShowsWhileWebViewIsVisible(true);
    279281
    280     if (IsWindowVisible(m_hwnd))
     282    if (creatingHighlight && IsWindowVisible(m_hwnd))
    281283        m_highlight->placeBehindWindow(m_hwnd);
    282284}
Note: See TracChangeset for help on using the changeset viewer.