Changeset 34011 in webkit

Timestamp:

May 21, 2008 10:59:24 PM (16 years ago)

Author:

Adam Roben

Message:

Fix Bug 19173: Tool tips for Inspector debugger status bar buttons are wrong/missing

<​https://bugs.webkit.org/show_bug.cgi?id=19173>

Reviewed by Tim Hatcher.

• manual-tests/inspector/debugger-status-bar-buttons-state.html: Added.
• page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging): Call _clearInterface (which updates the buttons' tool tips) after attaching/detaching the debugger so that the buttons will reflect the new state. (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): Set the title of the pauseOnExceptionsButton, not the debuggingButton.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/inspector/debugger-status-bar-buttons-state.html (added)
• page/inspector/ScriptsPanel.js (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-05-21  Adam Roben  <aroben@apple.com>
+
+        Fix Bug 19173: Tool tips for Inspector debugger status bar buttons are
+        wrong/missing
+
+        <https://bugs.webkit.org/show_bug.cgi?id=19173>
+
+        Reviewed by Tim Hatcher.
+
+        * manual-tests/inspector/debugger-status-bar-buttons-state.html:
+        Added.
+        * page/inspector/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._toggleDebugging): Call
+        _clearInterface (which updates the buttons' tool tips) after
+        attaching/detaching the debugger so that the buttons will reflect the
+        new state.
+        (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
+        Set the title of the pauseOnExceptionsButton, not the debuggingButton.
+
 2008-05-20  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/page/inspector/ScriptsPanel.js

@@ -545 +545 @@
     {
         if (InspectorController.pauseOnExceptions()) {
-            this.debuggingButton.title = WebInspector.UIString("Pause on exceptions.");
+            this.pauseOnExceptionButtons.title = WebInspector.UIString("Pause on exceptions.");
             this.pauseOnExceptionButtons.addStyleClass("toggled-on");
         } else {
-            this.debuggingButton.title = WebInspector.UIString("Don't pause on exceptions.");
+            this.pauseOnExceptionButtons.title = WebInspector.UIString("Don't pause on exceptions.");
             this.pauseOnExceptionButtons.removeStyleClass("toggled-on");
         }
@@ -608 +608 @@
         this._stepping = false;
 
-        this._clearInterface();
-
         if (InspectorController.debuggerAttached()) {
             this.element.appendChild(this.attachOverlayElement);
@@ -617 +615 @@
             InspectorController.startDebuggingAndReloadInspectedPage();
         }
+
+        this._clearInterface();
     },