Changeset 34073 in webkit


Ignore:
Timestamp:
May 23, 2008 3:43:08 AM (16 years ago)
Author:
mjs@apple.com
Message:

JavaScriptCore:

2008-05-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Delete any existing properties before creating the function (this should really be done at execution time not codegen time).

LayoutTests:

2008-05-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
  • fast/js/function-redefinition-expected.txt: Added.
  • fast/js/function-redefinition.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r34071 r34073  
     12008-05-23  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Oliver.
     4       
     5        - fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
     6
     7        * VM/CodeGenerator.cpp:
     8        (KJS::CodeGenerator::CodeGenerator): Delete any existing
     9        properties before creating the function (this should really be
     10        done at execution time not codegen time).
     11
    1122008-05-16  Alp Toker  <alp@nuanti.com>
    213
  • trunk/JavaScriptCore/VM/CodeGenerator.cpp

    r34032 r34073  
    207207        for (size_t i = 0; i < functionStack.size(); ++i) {
    208208            FuncDeclNode* funcDecl = functionStack[i];
     209            if (globalObject->hasProperty(exec, funcDecl->m_ident) || symbolTable->contains(funcDecl->m_ident.ustring().rep())) {
     210                globalObject->putWithAttributes(exec, funcDecl->m_ident, jsUndefined(), 0);
     211                globalObject->deleteProperty(exec, funcDecl->m_ident);
     212            }
    209213            emitNewFunction(addVar(funcDecl->m_ident, false), funcDecl);
    210214        }
  • trunk/LayoutTests/ChangeLog

    r34069 r34073  
     12008-05-23  Maciej Stachowiak  <mjs@apple.com>
     2
     3        Reviewed by Oliver.
     4       
     5        - test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
     6
     7        * fast/js/function-redefinition-expected.txt: Added.
     8        * fast/js/function-redefinition.html: Added.
     9
    1102008-05-23  Mark Rowe  <mrowe@apple.com>
    211
Note: See TracChangeset for help on using the changeset viewer.