Changeset 34367 in webkit

Timestamp:

Jun 4, 2008 3:04:32 PM (16 years ago)

Author:

Beth Dakin

Message:

2008-06-03 Beth Dakin <Beth Dakin>

Reviewed by Adele.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19381 WebKit
Crashing Constantly on Gmail with accessibility turned on

There was a missing null-check!

• page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-06-03  Beth Dakin  <bdakin@apple.com>
+
+        Reviewed by Adele.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=19381 WebKit 
+        Crashing Constantly on Gmail with accessibility turned on
+
+        There was a missing null-check!
+
+        * page/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::roleValue):
+
 2008-06-04  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/page/AccessibilityRenderObject.cpp

@@ -1999 +1999 @@
         return HeadingRole;
     
-    if (m_renderer->isBlockFlow() || node->hasTagName(labelTag))
+    if (m_renderer->isBlockFlow() || (node && node->hasTagName(labelTag)))
         return GroupRole;