Changeset 34409 in webkit

Timestamp:

Jun 6, 2008 3:51:19 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2008-06-06 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= ^{= $= should all accept the empty string, but match nothing}

Test: fast/css/begin-end-contain-selector-empty-value.html

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

2008-06-06 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=19407
CSS3 Selector Test: *= ~= ^{= $= should all accept the empty string, but match nothing.}

• fast/css/begin-end-contain-selector-empty-value.html: Added.
• platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/begin-end-contain-selector-empty-value.html (added)
• LayoutTests/platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSStyleSelector.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-06-06  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by Darin Adler.
+
+        Test for https://bugs.webkit.org/show_bug.cgi?id=19407 
+        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing.
+
+        * fast/css/begin-end-contain-selector-empty-value.html: Added.
+        * platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.
+
 2008-06-06  Anthony Ricaud  <rik24d@gmail.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-06-06  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by Darin Adler.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=19407 
+        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing
+
+        Test: fast/css/begin-end-contain-selector-empty-value.html
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
+
 2008-06-06  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/css/CSSStyleSelector.cpp

@@ -1578 +1578 @@
         }
         case CSSSelector::Contain:
-            if (!value.contains(sel->m_value, caseSensitive))
+            if (!value.contains(sel->m_value, caseSensitive) || sel->m_value.isEmpty())
                 return false;
             break;
         case CSSSelector::Begin:
-            if (!value.startsWith(sel->m_value, caseSensitive))
+            if (!value.startsWith(sel->m_value, caseSensitive) || sel->m_value.isEmpty())
                 return false;
             break;
         case CSSSelector::End:
-            if (!value.endsWith(sel->m_value, caseSensitive))
+            if (!value.endsWith(sel->m_value, caseSensitive) || sel->m_value.isEmpty())
                 return false;
             break;