Changeset 34456 in webkit

Timestamp:

Jun 8, 2008 1:57:48 PM (16 years ago)

Author:

Adam Roben

Message:

Fix Bug 18837: Database panel fails to display tables if any value is NULL

<​https://bugs.webkit.org/show_bug.cgi?id=18837>

Reviewed by Darin Adler.

Test: manual-tests/inspector/display-sql-null.html

• manual-tests/inspector/display-sql-null.html: Added.
• page/inspector/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all objects to strings before operating on them.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/inspector/display-sql-null.html (added)
• page/inspector/DatabasesPanel.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-06-08  Adam Roben  <aroben@apple.com>
+
+        Fix Bug 18837: Database panel fails to display tables if any value is
+        NULL
+
+        <https://bugs.webkit.org/show_bug.cgi?id=18837>
+
+        Reviewed by Darin Adler.
+
+        Test: manual-tests/inspector/display-sql-null.html
+
+        * manual-tests/inspector/display-sql-null.html: Added.
+        * page/inspector/DatabasesPanel.js:
+        (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all
+        objects to strings before operating on them.
+
 2008-06-08  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/page/inspector/DatabasesPanel.js

@@ -186 +186 @@
             var row = rows.item(i);
             for (var columnIdentifier in row) {
-                var text = row[columnIdentifier];
+                // FIXME: (Bug 19439) We should specially format SQL NULL here
+                // (which is represented by JavaScript null here, and turned
+                // into the string "null" by the String() function).
+                var text = String(row[columnIdentifier]);
                 data[columnIdentifier] = text;
                 if (text.length > columns[columnIdentifier].width)