Changeset 34730 in webkit

Timestamp:

Jun 22, 2008 5:55:33 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2008-06-22 kuchhal <​kuchhal@yahoo.com>

Reviewed by Darin Adler.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19696
Bug 19696: Memory leak in WebCore/editing/DeleteButtonController.cpp

• editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Delete the Image instance if the platform resource could not be loaded.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/DeleteButtonController.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-06-22  kuchhal  <kuchhal@yahoo.com>
+
+        Reviewed by Darin Adler.
+
+        Fix https://bugs.webkit.org/show_bug.cgi?id=19696
+        Bug 19696: Memory leak in WebCore/editing/DeleteButtonController.cpp
+
+        * editing/DeleteButtonController.cpp:
+        (WebCore::DeleteButtonController::createDeletionUI): Delete the Image instance
+        if the platform resource could not be loaded.
+
 2008-06-22  kuchhal  <kuchhal@yahoo.com>
 

trunk/WebCore/editing/DeleteButtonController.cpp

@@ -197 +197 @@
 
     Image* buttonImage = Image::loadPlatformResource("deleteButton");
-    if (buttonImage->isNull())
-        return;
+    if (buttonImage->isNull()) {
+        delete buttonImage;
+        return;
+    }
     
     button->setCachedImage(new CachedImage(buttonImage));