Changeset 34731 in webkit

Timestamp:

Jun 22, 2008 5:58:21 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2008-06-22 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=19675
Bug 19675: [GTK] negative text-shadows are not rendered

• platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs): The IntSize::isEmpty() call checks that the sizes are > 0, while we need to check for != 0.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cairo/FontCairo.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-06-22  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>
+
+        Reviewed by Dan Bernstein.
+
+        Fix https://bugs.webkit.org/show_bug.cgi?id=19675
+        Bug 19675: [GTK] negative text-shadows are not rendered
+
+        * platform/graphics/cairo/FontCairo.cpp:
+        (WebCore::Font::drawGlyphs): The IntSize::isEmpty() call checks that the
+        sizes are > 0, while we need to check for != 0.
+
 2008-06-22  kuchhal  <kuchhal@yahoo.com>
 

trunk/WebCore/platform/graphics/cairo/FontCairo.cpp

@@ -61 +61 @@
 
     // TODO: Blur support
-    bool hasShadow = context->textDrawingMode() == cTextFill && shadowColor.isValid() && !shadowSize.isEmpty();
+    bool hasShadow = context->textDrawingMode() == cTextFill && shadowColor.isValid() && (shadowSize.width() || shadowSize.height());
     if (hasShadow) {
         // Disable graphics context shadows (not yet implemented) and paint them manually