Changeset 35053 in webkit


Ignore:
Timestamp:
Jul 7, 2008 6:25:36 PM (16 years ago)
Author:
cwzwarich@webkit.org
Message:

2008-07-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff.

Bug 19926: URL causes crash within a minute
<https://bugs.webkit.org/show_bug.cgi?id=19926>

Add a check that lastGlobalObject is non-null in Machine::execute()
before copying its globals to the current register file.

In theory, it is possible to make a test case for this, but it will
take a while to get it right.

  • VM/Machine.cpp: (KJS::Machine::execute):
Location:
trunk/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r35046 r35053  
     12008-07-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
     2
     3        Reviewed by Geoff.
     4
     5        Bug 19926: URL causes crash within a minute
     6        <https://bugs.webkit.org/show_bug.cgi?id=19926>
     7
     8        Add a check that lastGlobalObject is non-null in Machine::execute()
     9        before copying its globals to the current register file.
     10
     11        In theory, it is possible to make a test case for this, but it will
     12        take a while to get it right.
     13
     14        * VM/Machine.cpp:
     15        (KJS::Machine::execute):
     16
    1172008-07-07  Darin Adler  <darin@apple.com>
    218
  • trunk/JavaScriptCore/VM/Machine.cpp

    r35046 r35053  
    710710    }
    711711
    712     if (m_reentryDepth && globalObject != lastGlobalObject)
     712    if (m_reentryDepth && lastGlobalObject && globalObject != lastGlobalObject)
    713713        lastGlobalObject->copyGlobalsTo(m_registerFile);
    714714
Note: See TracChangeset for help on using the changeset viewer.