Changeset 35138 in webkit

Timestamp:

Jul 11, 2008 3:34:42 PM (16 years ago)

Author:

dino@apple.com

Message:

2008-07-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Bug 18885: RenderLayer::enclosingPositionedAncestor() should
look for transforms, since transforms create containing
blocks.
<​https://bugs.webkit.org/show_bug.cgi?id=18885>

Test: fast/transforms/transform-positioned-ancestor.html

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/transforms/transform-positioned-ancestor.html (added)
• LayoutTests/platform/mac/fast/transforms/transform-positioned-ancestor-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderLayer.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-07-11  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dave Hyatt
+
+        Test for <https://bugs.webkit.org/show_bug.cgi?id=18885>
+        (requires visual inspection or pixel test).
+        
+        * fast/transforms/transform-positioned-ancestor.html: Added.
+        * platform/mac/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
+
 2008-07-11  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-07-11  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dave Hyatt
+
+        Bug 18885: RenderLayer::enclosingPositionedAncestor() should
+        look for transforms, since transforms create containing
+        blocks.
+        <https://bugs.webkit.org/show_bug.cgi?id=18885>
+
+        Test: fast/transforms/transform-positioned-ancestor.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::stackingContext):
+        (WebCore::RenderLayer::enclosingPositionedAncestor):
+        (WebCore::RenderLayer::enclosingTransformedAncestor):
+
 2008-07-11  Jacob Refstrup  <jacob.refstrup@hp.com>
 

trunk/WebCore/rendering/RenderLayer.cpp

@@ -426 +426 @@
     for ( ; curr && !curr->m_object->isRenderView() && !curr->m_object->isRoot() &&
           curr->m_object->style()->hasAutoZIndex();
-          curr = curr->parent()) { };
+          curr = curr->parent()) { }
     return curr;
 }
@@ -433 +433 @@
 {
     RenderLayer* curr = parent();
-    for ( ; curr && !curr->m_object->isRenderView() && !curr->m_object->isPositioned() && !curr->m_object->isRelPositioned();
-         curr = curr->parent()) { };
+    for ( ; curr && !curr->m_object->isRenderView() && !curr->m_object->isPositioned() && !curr->m_object->isRelPositioned() && !curr->m_object->hasTransform();
+         curr = curr->parent()) { }
     return curr;
 }
@@ -442 +442 @@
     RenderLayer* curr = parent();
     for ( ; curr && !curr->m_object->isRenderView() && !curr->transform(); curr = curr->parent())
-        { };
+        { }
     return curr;
 }