Changeset 35313 in webkit

Timestamp:

Jul 23, 2008 7:47:33 PM (16 years ago)

Author:

timothy@apple.com

Message:

Added TreeOutline.removeChildAtIndex and TreeElement.removeChildAtIndex
for efficiency of callers that know the index of the child. This
will be used in an upcoming change.

Reviewed by Adam Roben.

• page/inspector/treeoutline.js: (TreeOutline._removeChildAtIndex): Renamed from _removeChild and modified to take an index. (TreeOutline._removeChild): Call _removeChildAtIndex with the child index found using indexOf. (TreeOutline.prototype.removeChildAtIndex): Added. Calls TreeOutline._removeChildAtIndex. (TreeElement.prototype.removeChildAtIndex): Ditto.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/treeoutline.js (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-07-21  Timothy Hatcher  <timothy@apple.com>
+
+        Added TreeOutline.removeChildAtIndex and TreeElement.removeChildAtIndex
+        for efficiency of callers that know the index of the child. This
+        will be used in an upcoming change.
+
+        Reviewed by Adam Roben.
+
+        * page/inspector/treeoutline.js:
+        (TreeOutline._removeChildAtIndex): Renamed from _removeChild
+        and modified to take an index.
+        (TreeOutline._removeChild): Call _removeChildAtIndex with the
+        child index found using indexOf.
+        (TreeOutline.prototype.removeChildAtIndex): Added. Calls
+        TreeOutline._removeChildAtIndex.
+        (TreeElement.prototype.removeChildAtIndex): Ditto.
+
 2008-07-21  Timothy Hatcher  <timothy@apple.com>
 

trunk/WebCore/page/inspector/treeoutline.js

@@ -134 +134 @@
 }
 
-TreeOutline._removeChild = function(child)
-{
-    if (!child)
-        throw("child can't be undefined or null");
-
-    for (var i = 0; i < this.children.length; ++i) {
-        if (this.children[i] === child) {
-            this.children.splice(i, 1);
-            break;
-        }
-    }
+TreeOutline._removeChildAtIndex = function(childIndex)
+{
+    if (childIndex < 0 || childIndex >= this.children.length)
+        throw("childIndex out of range");
+
+    var child = this.children[childIndex];
+    this.children.splice(childIndex, 1);
 
     child.deselect();
@@ -160 +156 @@
     child.nextSibling = null;
     child.previousSibling = null;
+}
+
+TreeOutline._removeChild = function(child)
+{
+    if (!child)
+        throw("child can't be undefined or null");
+
+    var childIndex = this.children.indexOf(child);
+    if (childIndex === -1)
+        throw("child not found in this node's children");
+
+    TreeOutline._removeChildAtIndex.call(this, childIndex);
 }
 
@@ -396 +404 @@
 TreeOutline.prototype.insertChild = TreeOutline._insertChild;
 TreeOutline.prototype.removeChild = TreeOutline._removeChild;
+TreeOutline.prototype.removeChildAtIndex = TreeOutline._removeChildAtIndex;
 TreeOutline.prototype.removeChildren = TreeOutline._removeChildren;
 TreeOutline.prototype.removeChildrenRecursive = TreeOutline._removeChildrenRecursive;
@@ -492 +501 @@
 TreeElement.prototype.insertChild = TreeOutline._insertChild;
 TreeElement.prototype.removeChild = TreeOutline._removeChild;
+TreeElement.prototype.removeChildAtIndex = TreeOutline._removeChildAtIndex;
 TreeElement.prototype.removeChildren = TreeOutline._removeChildren;
 TreeElement.prototype.removeChildrenRecursive = TreeOutline._removeChildrenRecursive;