Changeset 35323 in webkit

Timestamp:

Jul 24, 2008 3:16:51 AM (16 years ago)

Author:

oliver@apple.com

Message:

Bug 20142: REGRESSION(r35245): /=/ weirdness
<​https://bugs.webkit.org/show_bug.cgi?id=20142>

Reviewed by Alexey Proskuryakov.

When adding all the meta data needed for exception error messages
I accidentally clobbered the handling of regex beginning with /=.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/grammar.y (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/regexp-divequal-expected.txt (added)
• LayoutTests/fast/js/regexp-divequal.html (added)
• LayoutTests/fast/js/resources/regexp-divequal.js (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-07-24  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Bug 20142: REGRESSION(r35245): /=/ weirdness
+        <https://bugs.webkit.org/show_bug.cgi?id=20142>
+
+        When adding all the meta data needed for exception error messages
+        I accidentally clobbered the handling of regex beginning with /=.
+
+        * kjs/grammar.y:
+
 2008-07-23  Alp Toker  <alp@nuanti.com>
 

trunk/JavaScriptCore/kjs/grammar.y

@@ -298 +298 @@
                                             if (!l.scanRegExp())
                                                 YYABORT;
-                                            RegExpNode* node = new RegExpNode(GLOBAL_DATA, l.pattern(), l.flags());
+                                            RegExpNode* node = new RegExpNode(GLOBAL_DATA, "=" + l.pattern(), l.flags());
                                             int size = l.pattern().size() + 2; // + 2 for the two /'s
                                             SET_EXCEPTION_LOCATION(node, @1.first_column, @1.first_column + size, @1.first_column + size);

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-07-24  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Test cases for regex starting with /=
+
+        * fast/js/regexp-divequal-expected.txt: Added.
+        * fast/js/regexp-divequal.html: Added.
+        * fast/js/resources/regexp-divequal.js: Added.
+
 2008-07-23  Julien Chaffraix  <jchaffraix@webkit.org>