Changeset 35381 in webkit


Ignore:
Timestamp:
Jul 26, 2008 10:08:31 PM (16 years ago)
Author:
mrowe@apple.com
Message:

2008-07-26 Michelangelo De Simone <michelangelo@me.com>

Reviewed by Adele Petersen.

Added the simple willValidate attribute to form controls according to
WebForms 2 spec.

URL: http://www.w3.org/TR/web-forms-2/#willvalidate

Tests: fast/forms/willvalidate-000.html

fast/forms/willvalidate-001.html
fast/forms/willvalidate-002.html
fast/forms/willvalidate-003.html
fast/forms/willvalidate-004.html
fast/forms/willvalidate-005.html
fast/forms/willvalidate-006.html
fast/forms/willvalidate-007.html
fast/forms/willvalidate-008.html
fast/forms/willvalidate-009.html

  • html/HTMLButtonElement.h: Added willValidate(), always false.
  • html/HTMLButtonElement.idl: willValidate attribute exposed.
  • html/HTMLFieldSetElement.h: Added willValidate(), always false.
  • html/HTMLFieldSetElement.idl: willValidate attribute exposed.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate): Added base willValidate() implementation.
  • html/HTMLFormControlElement.h: Added willValidate().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate): Added willValidate(), checks for input type.
  • html/HTMLInputElement.h: Added willValidate()
  • html/HTMLInputElement.idl: willValidate attribute exposed.
  • html/HTMLSelectElement.idl: willValidate attribute exposed.
  • html/HTMLTextAreaElement.idl: willValidate attribute exposed.

2008-07-26 Michelangelo De Simone <m.des@mac.com>

Reviewed by Adele Petersen.

Test suite for the willValidate form controls attribute.

  • fast/forms/willvalidate-000-expected.txt: Added.
  • fast/forms/willvalidate-000.html: Added.
  • fast/forms/willvalidate-001-expected.txt: Added.
  • fast/forms/willvalidate-001.html: Added.
  • fast/forms/willvalidate-002-expected.txt: Added.
  • fast/forms/willvalidate-002.html: Added.
  • fast/forms/willvalidate-003-expected.txt: Added.
  • fast/forms/willvalidate-003.html: Added.
  • fast/forms/willvalidate-004-expected.txt: Added.
  • fast/forms/willvalidate-004.html: Added.
  • fast/forms/willvalidate-005-expected.txt: Added.
  • fast/forms/willvalidate-005.html: Added.
  • fast/forms/willvalidate-006-expected.txt: Added.
  • fast/forms/willvalidate-006.html: Added.
  • fast/forms/willvalidate-007-expected.txt: Added.
  • fast/forms/willvalidate-007.html: Added.
  • fast/forms/willvalidate-008-expected.txt: Added.
  • fast/forms/willvalidate-008.html: Added.
  • fast/forms/willvalidate-009-expected.txt: Added.
  • fast/forms/willvalidate-009.html: Added.
Location:
trunk
Files:
20 added
13 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r35379 r35381  
     12008-07-26  Michelangelo De Simone  <m.des@mac.com>
     2
     3        Reviewed by Adele Petersen.
     4
     5        Test suite for the willValidate form controls attribute.
     6
     7        * fast/forms/willvalidate-000-expected.txt: Added.
     8        * fast/forms/willvalidate-000.html: Added.
     9        * fast/forms/willvalidate-001-expected.txt: Added.
     10        * fast/forms/willvalidate-001.html: Added.
     11        * fast/forms/willvalidate-002-expected.txt: Added.
     12        * fast/forms/willvalidate-002.html: Added.
     13        * fast/forms/willvalidate-003-expected.txt: Added.
     14        * fast/forms/willvalidate-003.html: Added.
     15        * fast/forms/willvalidate-004-expected.txt: Added.
     16        * fast/forms/willvalidate-004.html: Added.
     17        * fast/forms/willvalidate-005-expected.txt: Added.
     18        * fast/forms/willvalidate-005.html: Added.
     19        * fast/forms/willvalidate-006-expected.txt: Added.
     20        * fast/forms/willvalidate-006.html: Added.
     21        * fast/forms/willvalidate-007-expected.txt: Added.
     22        * fast/forms/willvalidate-007.html: Added.
     23        * fast/forms/willvalidate-008-expected.txt: Added.
     24        * fast/forms/willvalidate-008.html: Added.
     25        * fast/forms/willvalidate-009-expected.txt: Added.
     26        * fast/forms/willvalidate-009.html: Added.
     27
    1282008-07-26  Dan Bernstein  <mitz@apple.com>
    229
  • trunk/WebCore/ChangeLog

    r35380 r35381  
     12008-07-26  Michelangelo De Simone  <michelangelo@me.com>
     2
     3        Reviewed by Adele Petersen.
     4
     5        Added the simple willValidate attribute to form controls according to
     6        WebForms 2 spec.
     7
     8        URL: http://www.w3.org/TR/web-forms-2/#willvalidate
     9
     10        Tests: fast/forms/willvalidate-000.html
     11               fast/forms/willvalidate-001.html
     12               fast/forms/willvalidate-002.html
     13               fast/forms/willvalidate-003.html
     14               fast/forms/willvalidate-004.html
     15               fast/forms/willvalidate-005.html
     16               fast/forms/willvalidate-006.html
     17               fast/forms/willvalidate-007.html
     18               fast/forms/willvalidate-008.html
     19               fast/forms/willvalidate-009.html
     20
     21        * html/HTMLButtonElement.h: Added willValidate(), always false.
     22        * html/HTMLButtonElement.idl: willValidate attribute exposed.
     23        * html/HTMLFieldSetElement.h: Added willValidate(), always false.
     24        * html/HTMLFieldSetElement.idl: willValidate attribute exposed.
     25        * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate):
     26        Added base willValidate() implementation.
     27        * html/HTMLFormControlElement.h: Added willValidate().
     28        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate):
     29        Added willValidate(), checks for input type.
     30        * html/HTMLInputElement.h: Added willValidate()
     31        * html/HTMLInputElement.idl: willValidate attribute exposed.
     32        * html/HTMLSelectElement.idl: willValidate attribute exposed.
     33        * html/HTMLTextAreaElement.idl: willValidate attribute exposed.
     34
    1352008-07-26  Mark Rowe  <mrowe@apple.com>
    236
  • trunk/WebCore/html/HTMLButtonElement.h

    r34559 r35381  
    5757    String value() const;
    5858    void setValue(const String&);
     59
     60    virtual bool willValidate() const { return false; }
    5961   
    6062private:
  • trunk/WebCore/html/HTMLButtonElement.idl

    r34626 r35381  
    3333        readonly attribute  DOMString            type;
    3434                 attribute  [ConvertNullToNullString] DOMString            value;
    35 
     35        readonly attribute boolean               willValidate;
    3636        void click();
    3737    };
  • trunk/WebCore/html/HTMLFieldSetElement.h

    r34559 r35381  
    5050    virtual RenderObject* createRenderer(RenderArena*, RenderStyle*);
    5151    virtual const AtomicString& type() const;
     52
     53    virtual bool willValidate() const { return false; }
    5254};
    5355
  • trunk/WebCore/html/HTMLFieldSetElement.idl

    r29672 r35381  
    2626    ] HTMLFieldSetElement : HTMLElement {
    2727        readonly attribute HTMLFormElement form;
     28        readonly attribute boolean         willValidate;
    2829    };
    2930
  • trunk/WebCore/html/HTMLFormControlElement.cpp

    r34629 r35381  
    224224    return Element::tabIndex();
    225225}
     226
     227bool HTMLFormControlElement::willValidate() const
     228{
     229    // FIXME: Implementation shall be completed with these checks:
     230    //      The control does not have a repetition template as an ancestor.
     231    //      The control does not have a datalist element as an ancestor.
     232    //      The control is not an output element.
     233    return form() && name().length() && !disabled() && !isReadOnlyControl();
     234}
    226235   
    227236bool HTMLFormControlElement::supportsFocus() const
  • trunk/WebCore/html/HTMLFormControlElement.h

    r34629 r35381  
    9494    short tabIndex() const;
    9595
     96    virtual bool willValidate() const;
     97
    9698    void formDestroyed() { m_form = 0; }
    9799
  • trunk/WebCore/html/HTMLInputElement.cpp

    r35362 r35381  
    15951595}
    15961596
     1597bool HTMLInputElement::willValidate() const
     1598{
     1599    // FIXME: This shall check for new WF2 input types too
     1600    return HTMLFormControlElementWithState::willValidate() && inputType() != HIDDEN &&
     1601           inputType() != BUTTON && inputType() != RESET;
     1602}
    15971603} // namespace
  • trunk/WebCore/html/HTMLInputElement.h

    r35362 r35381  
    203203    virtual void getSubresourceAttributeStrings(Vector<String>&) const;
    204204   
     205    virtual bool willValidate() const;
     206
    205207protected:
    206208    virtual void willMoveToNewOwnerDocument();
  • trunk/WebCore/html/HTMLInputElement.idl

    r34724 r35381  
    5050                 attribute [ConvertNullToNullString] DOMString useMap;
    5151                 attribute [ConvertNullToNullString] DOMString value;
    52        
     52        readonly attribute boolean         willValidate;
    5353        void               select();
    5454        void               click();
  • trunk/WebCore/html/HTMLSelectElement.idl

    r34626 r35381  
    4242
    4343        readonly attribute HTMLFormElement form;
     44        readonly attribute boolean         willValidate;
    4445
    4546        // Modified in DOM Level 2:
  • trunk/WebCore/html/HTMLTextAreaElement.idl

    r34626 r35381  
    4040        void     select();
    4141
     42        readonly attribute boolean         willValidate;
     43
    4244       // WinIE & FireFox extension:
    4345                 attribute long selectionStart;
Note: See TracChangeset for help on using the changeset viewer.