Changeset 35381 in webkit
- Timestamp:
- Jul 26, 2008 10:08:31 PM (16 years ago)
- Location:
- trunk
- Files:
-
- 20 added
- 13 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r35379 r35381 1 2008-07-26 Michelangelo De Simone <m.des@mac.com> 2 3 Reviewed by Adele Petersen. 4 5 Test suite for the willValidate form controls attribute. 6 7 * fast/forms/willvalidate-000-expected.txt: Added. 8 * fast/forms/willvalidate-000.html: Added. 9 * fast/forms/willvalidate-001-expected.txt: Added. 10 * fast/forms/willvalidate-001.html: Added. 11 * fast/forms/willvalidate-002-expected.txt: Added. 12 * fast/forms/willvalidate-002.html: Added. 13 * fast/forms/willvalidate-003-expected.txt: Added. 14 * fast/forms/willvalidate-003.html: Added. 15 * fast/forms/willvalidate-004-expected.txt: Added. 16 * fast/forms/willvalidate-004.html: Added. 17 * fast/forms/willvalidate-005-expected.txt: Added. 18 * fast/forms/willvalidate-005.html: Added. 19 * fast/forms/willvalidate-006-expected.txt: Added. 20 * fast/forms/willvalidate-006.html: Added. 21 * fast/forms/willvalidate-007-expected.txt: Added. 22 * fast/forms/willvalidate-007.html: Added. 23 * fast/forms/willvalidate-008-expected.txt: Added. 24 * fast/forms/willvalidate-008.html: Added. 25 * fast/forms/willvalidate-009-expected.txt: Added. 26 * fast/forms/willvalidate-009.html: Added. 27 1 28 2008-07-26 Dan Bernstein <mitz@apple.com> 2 29 -
trunk/WebCore/ChangeLog
r35380 r35381 1 2008-07-26 Michelangelo De Simone <michelangelo@me.com> 2 3 Reviewed by Adele Petersen. 4 5 Added the simple willValidate attribute to form controls according to 6 WebForms 2 spec. 7 8 URL: http://www.w3.org/TR/web-forms-2/#willvalidate 9 10 Tests: fast/forms/willvalidate-000.html 11 fast/forms/willvalidate-001.html 12 fast/forms/willvalidate-002.html 13 fast/forms/willvalidate-003.html 14 fast/forms/willvalidate-004.html 15 fast/forms/willvalidate-005.html 16 fast/forms/willvalidate-006.html 17 fast/forms/willvalidate-007.html 18 fast/forms/willvalidate-008.html 19 fast/forms/willvalidate-009.html 20 21 * html/HTMLButtonElement.h: Added willValidate(), always false. 22 * html/HTMLButtonElement.idl: willValidate attribute exposed. 23 * html/HTMLFieldSetElement.h: Added willValidate(), always false. 24 * html/HTMLFieldSetElement.idl: willValidate attribute exposed. 25 * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate): 26 Added base willValidate() implementation. 27 * html/HTMLFormControlElement.h: Added willValidate(). 28 * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate): 29 Added willValidate(), checks for input type. 30 * html/HTMLInputElement.h: Added willValidate() 31 * html/HTMLInputElement.idl: willValidate attribute exposed. 32 * html/HTMLSelectElement.idl: willValidate attribute exposed. 33 * html/HTMLTextAreaElement.idl: willValidate attribute exposed. 34 1 35 2008-07-26 Mark Rowe <mrowe@apple.com> 2 36 -
trunk/WebCore/html/HTMLButtonElement.h
r34559 r35381 57 57 String value() const; 58 58 void setValue(const String&); 59 60 virtual bool willValidate() const { return false; } 59 61 60 62 private: -
trunk/WebCore/html/HTMLButtonElement.idl
r34626 r35381 33 33 readonly attribute DOMString type; 34 34 attribute [ConvertNullToNullString] DOMString value; 35 35 readonly attribute boolean willValidate; 36 36 void click(); 37 37 }; -
trunk/WebCore/html/HTMLFieldSetElement.h
r34559 r35381 50 50 virtual RenderObject* createRenderer(RenderArena*, RenderStyle*); 51 51 virtual const AtomicString& type() const; 52 53 virtual bool willValidate() const { return false; } 52 54 }; 53 55 -
trunk/WebCore/html/HTMLFieldSetElement.idl
r29672 r35381 26 26 ] HTMLFieldSetElement : HTMLElement { 27 27 readonly attribute HTMLFormElement form; 28 readonly attribute boolean willValidate; 28 29 }; 29 30 -
trunk/WebCore/html/HTMLFormControlElement.cpp
r34629 r35381 224 224 return Element::tabIndex(); 225 225 } 226 227 bool HTMLFormControlElement::willValidate() const 228 { 229 // FIXME: Implementation shall be completed with these checks: 230 // The control does not have a repetition template as an ancestor. 231 // The control does not have a datalist element as an ancestor. 232 // The control is not an output element. 233 return form() && name().length() && !disabled() && !isReadOnlyControl(); 234 } 226 235 227 236 bool HTMLFormControlElement::supportsFocus() const -
trunk/WebCore/html/HTMLFormControlElement.h
r34629 r35381 94 94 short tabIndex() const; 95 95 96 virtual bool willValidate() const; 97 96 98 void formDestroyed() { m_form = 0; } 97 99 -
trunk/WebCore/html/HTMLInputElement.cpp
r35362 r35381 1595 1595 } 1596 1596 1597 bool HTMLInputElement::willValidate() const 1598 { 1599 // FIXME: This shall check for new WF2 input types too 1600 return HTMLFormControlElementWithState::willValidate() && inputType() != HIDDEN && 1601 inputType() != BUTTON && inputType() != RESET; 1602 } 1597 1603 } // namespace -
trunk/WebCore/html/HTMLInputElement.h
r35362 r35381 203 203 virtual void getSubresourceAttributeStrings(Vector<String>&) const; 204 204 205 virtual bool willValidate() const; 206 205 207 protected: 206 208 virtual void willMoveToNewOwnerDocument(); -
trunk/WebCore/html/HTMLInputElement.idl
r34724 r35381 50 50 attribute [ConvertNullToNullString] DOMString useMap; 51 51 attribute [ConvertNullToNullString] DOMString value; 52 52 readonly attribute boolean willValidate; 53 53 void select(); 54 54 void click(); -
trunk/WebCore/html/HTMLSelectElement.idl
r34626 r35381 42 42 43 43 readonly attribute HTMLFormElement form; 44 readonly attribute boolean willValidate; 44 45 45 46 // Modified in DOM Level 2: -
trunk/WebCore/html/HTMLTextAreaElement.idl
r34626 r35381 40 40 void select(); 41 41 42 readonly attribute boolean willValidate; 43 42 44 // WinIE & FireFox extension: 43 45 attribute long selectionStart;
Note: See TracChangeset
for help on using the changeset viewer.