Changeset 35382 in webkit

Timestamp:

Jul 26, 2008 10:10:17 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2008-07-26 Anthony Ricaud <​rik24d@gmail.com>

Reviewed by Tim Hatcher.

<​https://bugs.webkit.org/show_bug.cgi?id=17589> Line highlighting should last longer

Restore the fade out effect after highlighting.

• page/inspector/SourceFrame.js: Add a class for fade-out effects and sets it at the end of highlighting time.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/SourceFrame.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-07-26  Anthony Ricaud  <rik24d@gmail.com>
+
+        Reviewed by Tim Hatcher.
+
+        <https://bugs.webkit.org/show_bug.cgi?id=17589> Line highlighting should last longer
+
+        Restore the fade out effect after highlighting.
+
+        * page/inspector/SourceFrame.js: Add a class for fade-out effects and sets it at the end of highlighting time.
+
 2008-07-26  Michelangelo De Simone  <michelangelo@me.com>
 

trunk/WebCore/page/inspector/SourceFrame.js

@@ -171 +171 @@
             return;
         sourceRow.addStyleClass("webkit-highlighted-line");
-        setTimeout(function() { sourceRow.removeStyleClass("webkit-highlighted-line") }, 300);
+        setTimeout(function() {
+            var line = sourceRow.getElementsByClassName('webkit-line-content')[0];
+            line.addStyleClass("webkit-fade-out-effect");
+            // FIXME Replace this timeout when ontransitionend is implemented
+            sourceRow.removeStyleClass("webkit-highlighted-line");
+            setTimeout(function () { line.removeStyleClass("webkit-fade-out-effect"); }, 1000);
+        }, 300);
     },
 
@@ -199 +205 @@
         styleText += ".webkit-height-sized-to-fit { overflow-y: hidden }\n";
         styleText += ".webkit-line-content { background-color: white; }\n";
-        styleText += ".webkit-highlighted-line .webkit-line-content { background-color: rgb(255, 255, 120); -webkit-transition-property: background-color; -webkit-transition-duration: 1s; }\n";
+        styleText += ".webkit-highlighted-line .webkit-line-content { background-color: rgb(255, 255, 120); }\n";
+        styleText += ".webkit-fade-out-effect { -webkit-transition-property: background-color; -webkit-transition-duration: 1s; }"
         styleText += ".webkit-javascript-comment { color: rgb(0, 116, 0); }\n";
         styleText += ".webkit-javascript-keyword { color: rgb(170, 13, 145); }\n";