Changeset 35486 in webkit

Timestamp:

Jul 31, 2008 10:20:00 AM (16 years ago)

Author:

Simon Hausmann

Message:

2008-07-31 Erik Bunce <​elbunce@thehive.com>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=20224

Include the Writing Direction sub-menu in the context menu of all
platforms but GTK. This fixes a regression introduced by revision
34426.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ContextMenu.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-07-31  Erik Bunce  <elbunce@thehive.com>
+
+        Reviewed by Simon.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20224
+
+        Include the Writing Direction sub-menu in the context menu of all
+        platforms but GTK. This fixes a regression introduced by revision
+        34426.
+
+        * platform/ContextMenu.cpp:
+        (WebCore::ContextMenu::populate):
+
 2008-07-31  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/platform/ContextMenu.cpp

@@ -154 +154 @@
     speechMenuItem.setSubMenu(&speechMenu);
 }
-
+#endif
+ 
+#if !PLATFORM(GTK)
 static void createAndAppendWritingDirectionSubMenu(const HitTestResult& result, ContextMenuItem& writingDirectionMenuItem)
 {
@@ -401 +403 @@
             createAndAppendSpeechSubMenu(m_hitTestResult, SpeechMenuItem);
             appendItem(SpeechMenuItem);
+#endif
+#if !PLATFORM(GTK)
             ContextMenuItem WritingDirectionMenuItem(SubmenuType, ContextMenuItemTagWritingDirectionMenu, 
                 contextMenuItemTagWritingDirectionMenu());