Changeset 35563 in webkit

Timestamp:

Aug 5, 2008 9:47:34 AM (16 years ago)

Author:

timothy@apple.com

Message:

Makes the selection surround just the name or value that was
double clicked when editing CSS properties. This regressed when
the Inspector started using focus/blur events, since a focus on
a content editable region changes the selection.

​https://bugs.webkit.org/show_bug.cgi?id=20280

Reviewed by Adam Roben.

• page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.startEditing): Change the selection after calling WebInspector.startEditing, since WebInspector.startEditing will set an initial selection due to a focus event.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/StylesSidebarPane.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-08-04  Timothy Hatcher  <timothy@apple.com>
+
+        Makes the selection surround just the name or value that was
+        double clicked when editing CSS properties. This regressed when
+        the Inspector started using focus/blur events, since a focus on
+        a content editable region changes the selection.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20280
+
+        Reviewed by Adam Roben.
+
+        * page/inspector/StylesSidebarPane.js:
+        (WebInspector.StylePropertyTreeElement.prototype.startEditing):
+        Change the selection after calling WebInspector.startEditing,
+        since WebInspector.startEditing will set an initial selection
+        due to a focus event.
+
 2008-08-04  Timothy Hatcher  <timothy@apple.com>
 

trunk/WebCore/page/inspector/StylesSidebarPane.js

@@ -688 +688 @@
             selectElement = this.listItemElement;
 
+        this.listItemElement.handleKeyEvent = this.editingKeyDown.bind(this);
+
+        WebInspector.startEditing(this.listItemElement, this.editingCommitted.bind(this), this.editingCancelled.bind(this), context);
         window.getSelection().setBaseAndExtent(selectElement, 0, selectElement, 1);
-
-        this.listItemElement.handleKeyEvent = this.editingKeyDown.bind(this);
-
-        WebInspector.startEditing(this.listItemElement, this.editingCommitted.bind(this), this.editingCancelled.bind(this), context);
     },