Changeset 35660 in webkit


Ignore:
Timestamp:
Aug 10, 2008 7:17:01 PM (16 years ago)
Author:
mrowe@apple.com
Message:

Fix crash in Acid3 in Windows and Gtk ports, introduced in r35590.

Reviewed by Cameron Zwarich.

  • bindings/js/ScriptControllerGtk.cpp: Fix the logic.
  • bindings/js/ScriptControllerWin.cpp: Ditto.
  • bindings/js/ScriptControllerQt.cpp: Switch to isPluginView for consistency with Gtk and Windows.
Location:
trunk/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r35659 r35660  
     12008-08-10  Mark Rowe  <mrowe@apple.com>
     2
     3        Reviewed by Cameron Zwarich.
     4
     5        Fix crash in Acid3 in Windows and Gtk ports, introduced in r35590.
     6
     7        * bindings/js/ScriptControllerGtk.cpp: Fix the logic.
     8        * bindings/js/ScriptControllerWin.cpp: Ditto.
     9        * bindings/js/ScriptControllerQt.cpp: Switch to isPluginView for consistency with Gtk and Windows.
     10
    1112008-08-10  Dan Bernstein  <mitz@apple.com>
    212

  • trunk/WebCore/bindings/js/ScriptControllerGtk.cpp

    r35599 r35660  
    4040PassRefPtr<KJS::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget)
    4141{
    42     if (widget->isPluginView())
     42    if (!widget->isPluginView())
    4343        return 0;
    4444

  • trunk/WebCore/bindings/js/ScriptControllerQt.cpp

    r35592 r35660  
    4949PassRefPtr<KJS::Bindings::Instance> ScriptController::createScriptInstanceForWidget(WebCore::Widget* widget)
    5050{
    51     if (widget->isFrameView())
     51    if (!widget->isPluginView())
    5252        return 0;
    5353    if (widget->isNPAPIPlugin())

  • trunk/WebCore/bindings/js/ScriptControllerWin.cpp

    r35592 r35660  
    3737PassRefPtr<KJS::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget)
    3838{
    39     if (widget->isPluginView())
     39    if (!widget->isPluginView())
    4040        return 0;
    4141
Note: See TracChangeset for help on using the changeset viewer.