Changeset 36051 in webkit


Ignore:
Timestamp:
Sep 2, 2008 11:59:03 PM (16 years ago)
Author:
mrowe@apple.com
Message:

2008-09-02 Robert Blaut <​webkit@blaut.biz>

Reviewed by Geoff Garen.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=16913>
Misplaced elements should not close DL lists.

Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):

2008-09-02 Robert Blaut <​webkit@blaut.biz>

Reviewed by Geoff Garen.

Test for <​https://bugs.webkit.org/show_bug.cgi?id=16913>
Misplaced elements should not close DL lists.

  • fast/invalid/test-case-tr-th-td-should-not-close-dl-list-expected.txt: Added.
  • fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html: Added.
  • platform/mac/fast/invalid/missing-dl-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-dl-end-tag-expected.png:
  • platform/mac/fast/invalid/missing-dl-end-tag-expected.txt:
  • platform/mac/fast/invalid/missing-dt-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-dt-end-tag-expected.png:
  • platform/mac/fast/invalid/missing-dt-end-tag-expected.txt:
Location:
trunk
Files:
2 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r36050 r36051  
     12008-09-02  Robert Blaut  <webkit@blaut.biz>
     2
     3        Reviewed by Geoff Garen.
     4
     5        Test for <https://bugs.webkit.org/show_bug.cgi?id=16913>
     6        Misplaced elements should not close DL lists.
     7
     8        * fast/invalid/test-case-tr-th-td-should-not-close-dl-list-expected.txt: Added.
     9        * fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html: Added.
     10        * platform/mac/fast/invalid/missing-dl-end-tag-expected.checksum:
     11        * platform/mac/fast/invalid/missing-dl-end-tag-expected.png:
     12        * platform/mac/fast/invalid/missing-dl-end-tag-expected.txt:
     13        * platform/mac/fast/invalid/missing-dt-end-tag-expected.checksum:
     14        * platform/mac/fast/invalid/missing-dt-end-tag-expected.png:
     15        * platform/mac/fast/invalid/missing-dt-end-tag-expected.txt:
     16
    1172008-09-02  Glenn Wilson  <wilsong@gmail.com>
    218

  • trunk/LayoutTests/platform/mac/fast/invalid/missing-dl-end-tag-expected.checksum

    r26026 r36051  
    1 b655d67f81197c4652633e0cd4fe4df3
     16f2ea9f017d3e4aaf5868f02bb810786

  • trunk/LayoutTests/platform/mac/fast/invalid/missing-dl-end-tag-expected.txt

    r30635 r36051  
    33layer at (0,0) size 800x600
    44  RenderBlock {HTML} at (0,0) size 800x600
    5     RenderBody {BODY} at (8,8) size 784x584
     5    RenderBody {BODY} at (8,8) size 784x576
    66      RenderBlock {DIV} at (0,0) size 784x18
    77        RenderText {#text} at (0,0) size 53x18
    … …  
    1515        RenderText {#text} at (0,0) size 12x18
    1616          text run at (0,0) width 12: "dl"
    17       RenderBlock (anonymous) at (0,68) size 784x18
    18         RenderText {#text} at (0,0) size 9x18
    19           text run at (0,0) width 9: "tr"
     17        RenderText {#text} at (12,0) size 9x18
     18          text run at (12,0) width 9: "tr"

  • trunk/LayoutTests/platform/mac/fast/invalid/missing-dt-end-tag-expected.checksum

    r26026 r36051  
    1 b02678643fa30e6276449956e73ec582
     1cee25f6224433d0f0a15962cdf972787

  • trunk/LayoutTests/platform/mac/fast/invalid/missing-dt-end-tag-expected.txt

    r30635 r36051  
    1515        RenderText {#text} at (0,0) size 12x18
    1616          text run at (0,0) width 12: "dt"
    17       RenderBlock (anonymous) at (0,36) size 784x18
    18         RenderText {#text} at (0,0) size 9x18
    19           text run at (0,0) width 9: "tr"
     17        RenderText {#text} at (12,0) size 9x18
     18          text run at (12,0) width 9: "tr"

  • trunk/WebCore/ChangeLog

    r36050 r36051  
     12008-09-02  Robert Blaut  <webkit@blaut.biz>
     2
     3        Reviewed by Geoff Garen.
     4
     5        Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
     6        Misplaced elements should not close DL lists.
     7
     8        Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html
     9
     10        * html/HTMLParser.cpp:
     11        (WebCore::HTMLParser::handleError):
     12
    1132008-09-02  Glenn Wilson  <wilsong@gmail.com>
    214

  • trunk/WebCore/html/HTMLParser.cpp

    r36026 r36051  
    521521                    reportError(MisplacedFramesetContentError, &localName);
    522522            }
    523         } else if (h->hasLocalName(addressTag) || h->hasLocalName(dlTag) || h->hasLocalName(dtTag)
    524                    || h->hasLocalName(fontTag) || h->hasLocalName(styleTag) || h->hasLocalName(titleTag)) {
     523        } else if (h->hasLocalName(addressTag) || h->hasLocalName(fontTag)
     524                   || h->hasLocalName(styleTag) || h->hasLocalName(titleTag)) {
    525525            reportError(MisplacedContentRetryError, &localName, &currentTagName);
    526526            popBlock(currentTagName);
Note: See TracChangeset for help on using the changeset viewer.