Changeset 37038 in webkit


Ignore:
Timestamp:
Sep 28, 2008 6:23:51 AM (16 years ago)
Author:
ap@webkit.org
Message:

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20366
Reproducible test failure for editing/undo/undo-iframe-location-change.html

This does not fix the problem, but makes the test more predictable by using iframe onload.
Also, makes the test runnable in browser. Turns out that the test reliably fails there too,
even without any special steps needed in DRT.

  • editing/undo/undo-iframe-location-change-expected.txt:
  • editing/undo/undo-iframe-location-change.html:
  • ChangeLog-2007-10-14: Added bug URLs for a patch that included this test.

WebCore:

  • ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r37009 r37038  
     12008-09-28  Alexey Proskuryakov  <ap@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=20366
     6        Reproducible test failure for editing/undo/undo-iframe-location-change.html
     7
     8        This does not fix the problem, but makes the test more predictable by using iframe onload.
     9        Also, makes the test runnable in browser. Turns out that the test reliably fails there too,
     10        even without any special steps needed in DRT.
     11
     12        * editing/undo/undo-iframe-location-change-expected.txt:
     13        * editing/undo/undo-iframe-location-change.html:
     14
     15        * ChangeLog-2007-10-14: Added bug URLs for a patch that included this test.
     16
    1172008-09-27  Dan Bernstein  <mitz@apple.com>
    218

  • trunk/LayoutTests/ChangeLog-2007-10-14

    r36097 r37038  
    5714657146        Reviewed by mjs
    5714757147       
    57148         <http://tinymce.moxiecode.com/example_full.php?example=true>
    57149         TinyMCE: Undo still enabled after a location change, crashes if performed
     57148        https://bugs.webkit.org/show_bug.cgi?id=7150
     57149        <rdar://4433765> TinyMCE: Undo still enabled after a location change, crashes if performed
    5715057150
    5715157151        * editing/undo/undo-iframe-location-change-expected.txt: Added.

  • trunk/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt

    r30635 r37038  
    1 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of BODY > HTML > #document to 1 of BODY > HTML > #document
    2 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
    3 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of BODY > HTML > #document to 0 of BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of BODY > HTML > #document to 0 of BODY > HTML > #document toDOMRange:range from 1 of #text > BODY > HTML > #document to 1 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    7 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    81
    92Success

  • trunk/LayoutTests/editing/undo/undo-iframe-location-change.html

    r17562 r37038  
    1 <script>
    2 if (window.layoutTestController)
    3      layoutTestController.dumpEditingCallbacks();
    4 </script>
    5 
    61<script src="../editing.js"></script>
    7 <iframe name="iframe" src="../resources/contenteditable-iframe-src.html"></iframe>
     2<iframe name="iframe" src="../resources/contenteditable-iframe-src.html" onload="runTest()"></iframe>
    83<ul id="console"></ul>
    94
    … …  
    1813
    1914function part1() {
    20 
    21     // Hack to focus the frame, should be able to do frames['iframe'].focus()
    22     eventSender.mouseMoveTo(50, 50);
    23     eventSender.mouseDown();
    24     eventSender.mouseUp();
     15    frames['iframe'].document.body.focus();
    2516   
    2617    // Hack to perform the editing command.  Should be able to
    2718    // call execCommand on the main document.
    2819    frames['iframe'].document.execCommand('InsertText', false, 'c');
    29    
     20
     21    if (frames['iframe'].document.body.innerText != 'c') {
     22        log("FAIL: could not insert text.");
     23        if (window.layoutTestController)
     24            layoutTestController.notifyDone();
     25        return;
     26    }
     27
     28    if (!document.queryCommandEnabled('Undo')) {
     29        log("FAIL: Undo is not enabled after text insertion.");
     30        if (window.layoutTestController)
     31            layoutTestController.notifyDone();
     32        return;
     33    }
     34
    3035    window.location = window.location.toString() + "?part2";
    3136}
    3237
    3338function part2() {
     39    if (frames['iframe'].document.body.innerText != '')
     40        log("FAIL: subframe still has old content after navigaiton.");
     41
    3442    if (!document.queryCommandEnabled('Undo'))
    3543        log("Success");
    3644    else
    37         log("Failure, Undo was still enabled after the location changed.");
     45        log("Failure, Undo was still enabled after the location changed (but at least we didn't crash!)");
    3846       
    39     window.layoutTestController.notifyDone();
     47    if (window.layoutTestController)
     48        layoutTestController.notifyDone();
    4049}
    4150
    4251function runTest() {
    43     if (!window.layoutTestController)
    44         return;
    45 
    4652    if (window.location.toString().indexOf("?part2") == -1) {
    47         window.layoutTestController.waitUntilDone();
    48         window.layoutTestController.dumpAsText();
    49         // Give the iframe a moment to come into being.
    50         window.setTimeout(part1, 100);
     53        part1();
    5154    } else {
    5255        part2();
    5356    }
    54 
    5557}
    5658
    57 runTest();
     59if (window.layoutTestController) {
     60    layoutTestController.waitUntilDone();
     61    layoutTestController.dumpAsText();
     62}
    5863
    5964</script>

  • trunk/WebCore/ChangeLog

    r37037 r37038  
     12008-09-28  Alexey Proskuryakov  <ap@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=20366
     6        Reproducible test failure for editing/undo/undo-iframe-location-change.html
     7
     8        * ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
     9
    1102008-09-28  Darin Adler  <darin@apple.com>
    211

  • trunk/WebCore/ChangeLog-2006-05-10

    r24788 r37038  
    1675016750        Reviewed by mjs
    1675116751       
    16752         <http://tinymce.moxiecode.com/example_full.php?example=true>
    16753         TinyMCE: Undo still enabled after a location change, crashes if performed
     16752        https://bugs.webkit.org/show_bug.cgi?id=7150
     16753        <rdar://4433765> TinyMCE: Undo still enabled after a location change, crashes if performed
    1675416754       
    1675516755        Can't clear undo/redo operations registered by subframes in didOpenURL,
Note: See TracChangeset for help on using the changeset viewer.