Changeset 37247 in webkit


Ignore:
Timestamp:
Oct 3, 2008 12:00:22 PM (15 years ago)
Author:
rwlbuis@webkit.org
Message:

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=20134
REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)

Make sure the input element gets the right default value when no value is set.

Test: fast/forms/range-default-value.html

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r37222 r37247  
     12008-10-03  Rob Buis  <buis@kde.org>
     2
     3        Reviewed by Darin.
     4
     5        Test for:
     6        https://bugs.webkit.org/show_bug.cgi?id=20134
     7        REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)
     8
     9        * fast/forms/range-default-value-expected.txt: Added.
     10        * fast/forms/range-default-value.html: Added.
     11
    1122008-10-02  Dan Bernstein  <mitz@apple.com>
    213
  • trunk/WebCore/ChangeLog

    r37244 r37247  
     12008-10-03  Rob Buis  <buis@kde.org>
     2
     3        Reviewed by Darin.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=20134
     6        REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)
     7
     8        Make sure the input element gets the right default value when no value is set.
     9
     10        Test: fast/forms/range-default-value.html
     11
     12        * rendering/RenderSlider.cpp:
     13        (WebCore::RenderSlider::setPositionFromValue):
     14
    1152008-10-03  David Hyatt  <hyatt@apple.com>
    216
  • trunk/WebCore/rendering/RenderSlider.cpp

    r35949 r37247  
    329329    setCurrentPosition((int)(factor * trackSize()));
    330330   
    331     if (val != oldVal)
     331    if (value.isNull() || val != oldVal)
    332332        static_cast<HTMLInputElement*>(node())->setValueFromRenderer(String::number(val));
    333333   
Note: See TracChangeset for help on using the changeset viewer.