Changeset 37679 in webkit

Timestamp:

Oct 18, 2008 2:23:59 PM (16 years ago)

Author:

jmalonzo@webkit.org

Message:

2008-10-18 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

[GTK] crash after selecting a file on an <input type=file>
​https://bugs.webkit.org/show_bug.cgi?id=21385

Follow Mac and Win's behaviors for Icon::paint

• platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::paint): check if painting is enabled before painting the icon

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gtk/IconGtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-10-18  Jan Michael Alonzo  <jmalonzo@webkit.org>
+
+        Reviewed by Alp Toker.
+
+        [GTK] crash after selecting a file on an <input type=file>
+        https://bugs.webkit.org/show_bug.cgi?id=21385
+
+        Follow Mac and Win's behaviors for Icon::paint
+
+        * platform/graphics/gtk/IconGtk.cpp:
+        (WebCore::Icon::paint): check if painting is enabled before
+        painting the icon
+
 2008-10-18  Zan Dobersek  <zandobersek@gmail.com>
 

trunk/WebCore/platform/graphics/gtk/IconGtk.cpp

@@ -106 +106 @@
 void Icon::paint(GraphicsContext* context, const IntRect& rect)
 {
+    if (context->paintingDisabled())
+        return;
+
     // TODO: Scale/clip the image if necessary.
     cairo_t* cr = context->platformContext();