Changeset 38003 in webkit

Timestamp:

Oct 30, 2008 12:18:47 PM (15 years ago)

Author:

alp@webkit.org

Message:

2008-10-30 Alp Toker <​alp@nuanti.com>

Reviewed by Dave Hyatt.

Fix GIF animations. WebCore will not update animated GIFs if
the WebView is marked offscreen so we need to call
frameView->setParentVisible() when necessary like the Mac and Win
ports do. Regression was introduced around r37155 during the
HostWindow refactor.

• WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/FrameLoaderClientGtk.cpp (modified) (2 diffs)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2008-10-30  Alp Toker  <alp@nuanti.com>
+
+        Reviewed by Dave Hyatt.
+
+        Fix GIF animations. WebCore will not update animated GIFs if
+        the WebView is marked offscreen so we need to call
+        frameView->setParentVisible() when necessary like the Mac and Win
+        ports do. Regression was introduced around r37155 during the
+        HostWindow refactor.
+
+        * WebCoreSupport/FrameLoaderClientGtk.cpp:
+        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
+
 2008-10-30  Alp Toker  <alp@nuanti.com>
 

trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

@@ -762 +762 @@
     WebKitWebView* containingWindow = getViewFromFrame(m_frame);
     bool isMainFrame = frame == page->mainFrame();
+
+    if (isMainFrame && frame->view())
+        frame->view()->setParentVisible(false);
+
     frame->setView(0);
 
@@ -778 +782 @@
     frameView->deref();
 
+    if (isMainFrame)
+        frameView->setParentVisible(true);
+
     if (frame->ownerRenderer())
         frame->ownerRenderer()->setWidget(frameView);