Changeset 38066 in webkit

Timestamp:

Nov 2, 2008 3:29:58 AM (15 years ago)

Author:

cwzwarich@webkit.org

Message:

2008-11-02 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 22035: Remove the '_' suffix on constructor parameter names for structs
<​https://bugs.webkit.org/show_bug.cgi?id=22035>

• API/JSCallbackObject.h: (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
• VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):
• wrec/WREC.h: (JSC::Quantifier::Quantifier):

Location:

trunk/JavaScriptCore

Files:

• API/JSCallbackObject.h (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• VM/CodeBlock.h (modified) (4 diffs)
• wrec/WREC.h (modified) (1 diff)

trunk/JavaScriptCore/API/JSCallbackObject.h

@@ -89 +89 @@
 
     struct JSCallbackObjectData {
-        JSCallbackObjectData(void* privateData_, JSClassRef jsClass_)
-            : privateData(privateData_)
-            , jsClass(jsClass_)
+        JSCallbackObjectData(void* privateData, JSClassRef jsClass)
+            : privateData(privateData)
+            , jsClass(jsClass)
         {
             JSClassRetain(jsClass);

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-11-02  Cameron Zwarich  <zwarich@apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        Bug 22035: Remove the '_' suffix on constructor parameter names for structs
+        <https://bugs.webkit.org/show_bug.cgi?id=22035>
+
+        * API/JSCallbackObject.h:
+        (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
+        * VM/CodeBlock.h:
+        (JSC::CodeBlock::CodeBlock):
+        (JSC::ProgramCodeBlock::ProgramCodeBlock):
+        (JSC::EvalCodeBlock::EvalCodeBlock):
+        * wrec/WREC.h:
+        (JSC::Quantifier::Quantifier):
+
 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
 

trunk/JavaScriptCore/VM/CodeBlock.h

@@ -246 +246 @@
 
     struct CodeBlock {
-        CodeBlock(ScopeNode* ownerNode_, CodeType codeType_, PassRefPtr<SourceProvider> source_, unsigned sourceOffset_)
-            : ownerNode(ownerNode_)
+        CodeBlock(ScopeNode* ownerNode, CodeType codeType, PassRefPtr<SourceProvider> source, unsigned sourceOffset)
+            : ownerNode(ownerNode)
             , globalData(0)
 #if ENABLE(CTI)
@@ -256 +256 @@
             , numVars(0)
             , numParameters(0)
-            , needsFullScopeChain(ownerNode_->needsActivation())
-            , usesEval(ownerNode_->usesEval())
-            , codeType(codeType_)
-            , source(source_)
-            , sourceOffset(sourceOffset_)
+            , needsFullScopeChain(ownerNode->needsActivation())
+            , usesEval(ownerNode->usesEval())
+            , codeType(codeType)
+            , source(source)
+            , sourceOffset(sourceOffset)
         {
             ASSERT(source);
@@ -372 +372 @@
 
     struct ProgramCodeBlock : public CodeBlock {
-        ProgramCodeBlock(ScopeNode* ownerNode_, CodeType codeType_, JSGlobalObject* globalObject_, PassRefPtr<SourceProvider> source_)
-            : CodeBlock(ownerNode_, codeType_, source_, 0)
-            , globalObject(globalObject_)
+        ProgramCodeBlock(ScopeNode* ownerNode, CodeType codeType, JSGlobalObject* globalObject, PassRefPtr<SourceProvider> source)
+            : CodeBlock(ownerNode, codeType, source, 0)
+            , globalObject(globalObject)
         {
             globalObject->codeBlocks().add(this);
@@ -389 +389 @@
 
     struct EvalCodeBlock : public ProgramCodeBlock {
-        EvalCodeBlock(ScopeNode* ownerNode_, JSGlobalObject* globalObject_, PassRefPtr<SourceProvider> source_)
-            : ProgramCodeBlock(ownerNode_, EvalCode, globalObject_, source_)
+        EvalCodeBlock(ScopeNode* ownerNode, JSGlobalObject* globalObject, PassRefPtr<SourceProvider> source)
+            : ProgramCodeBlock(ownerNode, EvalCode, globalObject, source)
         {
         }

trunk/JavaScriptCore/wrec/WREC.h

@@ -61 +61 @@
         }
 
-        Quantifier(Type type_, unsigned min_ = 0, unsigned max_ = noMaxSpecified)
-            : type(type_)
-            , min(min_)
-            , max(max_)
+        Quantifier(Type type, unsigned min = 0, unsigned max = noMaxSpecified)
+            : type(type)
+            , min(min)
+            , max(max)
         {
         }