Changeset 38240 in webkit

Timestamp:

Nov 8, 2008 8:11:26 PM (15 years ago)

Author:

Antti Koivisto

Message:

WebCore:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

Reset text decoder on flush so it does not pass through the BOM when it is reused.

Test: fast/encoding/css-cached-bom.html

• loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::flush):

LayoutTests:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

• fast/encoding/css-cached-bom.html: Added.
• fast/encoding/css-cached-bom-expected.txt: Added.
• fast/encoding/resources/css-cached-bom-frame.html: Added.
• fast/encoding/resources/utf-16-little-endian.css: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/encoding/css-cached-bom-expected.txt (added)
• LayoutTests/fast/encoding/css-cached-bom.html (added)
• LayoutTests/fast/encoding/resources/css-cached-bom-frame.html (added)
• LayoutTests/fast/encoding/resources/utf-16-little-endian.css (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/loader/TextResourceDecoder.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-11-08  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Sam Weinig.
+        
+        Test for https://bugs.webkit.org/show_bug.cgi?id=22141
+        REGRESSION: Safari error page is not fully styled when loaded from cache
+
+        * fast/encoding/css-cached-bom.html: Added.
+        * fast/encoding/css-cached-bom-expected.txt: Added.
+        * fast/encoding/resources/css-cached-bom-frame.html: Added.
+        * fast/encoding/resources/utf-16-little-endian.css: Added.
+
 2008-11-08  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-11-08  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Sam Weinig.
+        
+        Fix https://bugs.webkit.org/show_bug.cgi?id=22141
+        REGRESSION: Safari error page is not fully styled when loaded from cache
+        
+        Reset text decoder on flush so it does not pass through the BOM when it is reused.
+
+        Test: fast/encoding/css-cached-bom.html
+
+        * loader/TextResourceDecoder.cpp:
+        (WebCore::TextResourceDecoder::flush):
+
 2008-11-08  Kevin Ollivier  <kevino@theolliviers.com>
  

trunk/WebCore/loader/TextResourceDecoder.cpp

@@ -794 +794 @@
     String result = m_decoder.decode(m_buffer.data(), m_buffer.size(), true, m_contentType == XML, m_sawError);
     m_buffer.clear();
+    m_decoder.reset(m_decoder.encoding());
     return result;
 }