Changeset 38309 in webkit

Timestamp:

Nov 11, 2008 11:50:18 AM (15 years ago)

Author:

hyatt@apple.com

Message:

2008-11-11 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=17997

Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
is a Leopard-only workaround, since the API has been fixed on Snow Leopard.

Reviewed by John Sullivan

• platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cg/ImageCG.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-11-11  David Hyatt  <hyatt@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=17997
+
+        Stop using the new Leopard API tiling call for scaled tiles when drawing background images.  The method
+        is buggy.  Fall back to using the slower (and more correct) pattern tiling that Tiger still uses.  This
+        is a Leopard-only workaround, since the API has been fixed on Snow Leopard.
+
+        Reviewed by John Sullivan
+
+        * platform/graphics/cg/ImageCG.cpp:
+        (WebCore::Image::drawPattern):
+
 2008-11-10  David Hyatt  <hyatt@apple.com>
 

trunk/WebCore/platform/graphics/cg/ImageCG.cpp

@@ -252 +252 @@
     // overall image buffer needs to tile with "gaps", we can't use the optimized tiling call in that case.
     // FIXME: Could create WebKitSystemInterface SPI for CGCreatePatternWithImage2 and probably make Tiger tile faster as well.
+    // FIXME: We cannot use CGContextDrawTiledImage with scaled tiles on Leopard, because it suffers from rounding errors.  Snow Leopard is ok.
     float scaledTileWidth = tileRect.width() * narrowPrecisionToFloat(patternTransform.a());
     float w = CGImageGetWidth(tileImage);
+#ifdef BUILDING_ON_LEOPARD
+    if (w == size().width() && h == size().height() && scaledTileWidth == tileRect.width() && scaledTileHeight == tileRect.height())
+#else
     if (w == size().width() && h == size().height())
+#endif
         CGContextDrawTiledImage(context, FloatRect(adjustedX, adjustedY, scaledTileWidth, scaledTileHeight), subImage);
     else {