Changeset 38590 in webkit


Ignore:
Timestamp:
Nov 18, 2008 8:04:01 PM (15 years ago)
Author:
cwzwarich@webkit.org
Message:

2008-11-18 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak and Geoff Garen.

Bug 22287: ASSERTION FAILED: Not enough jumps linked in slow case codegen in CTI::privateCompileSlowCases())
<https://bugs.webkit.org/show_bug.cgi?id=22287>

Fix a typo in the number cell reuse code where the first and second
operands are sometimes confused.

JavaScriptcore:

  • jit/JIT.cpp: (JSC::JIT::compileBinaryArithOpSlowCase):

LayoutTests:

  • fast/js/number-cell-reuse-expected.txt: Added.
  • fast/js/number-cell-reuse.html: Added.
  • fast/js/resources/number-cell-reuse.js: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r38576 r38590  
     12008-11-18  Cameron Zwarich  <zwarich@apple.com>
     2
     3        Reviewed by Maciej Stachowiak and Geoff Garen.
     4
     5        Bug 22287: ASSERTION FAILED: Not enough jumps linked in slow case codegen in CTI::privateCompileSlowCases())
     6        <https://bugs.webkit.org/show_bug.cgi?id=22287>
     7
     8        Fix a typo in the number cell reuse code where the first and second
     9        operands are sometimes confused.
     10
     11        * jit/JIT.cpp:
     12        (JSC::JIT::compileBinaryArithOpSlowCase):
     13
    1142008-11-18  Dan Bernstein  <mitz@apple.com>
    215
  • trunk/JavaScriptCore/jit/JIT.cpp

    r38531 r38590  
    10461046    if (types.second().isReusable() && isSSE2Present()) {
    10471047        if (!types.first().definitelyIsNumber()) {
    1048             if (linkSlowCaseIfNotJSCell(++iter, src2))
     1048            if (linkSlowCaseIfNotJSCell(++iter, src1))
    10491049                ++iter;
    10501050            __ link(iter->from, here);
    10511051        }
    10521052        if (!types.second().definitelyIsNumber()) {
    1053             if (linkSlowCaseIfNotJSCell(++iter, src1))
     1053            if (linkSlowCaseIfNotJSCell(++iter, src2))
    10541054                ++iter;
    10551055            __ link(iter->from, here);
  • trunk/LayoutTests/ChangeLog

    r38585 r38590  
     12008-11-18  Cameron Zwarich  <zwarich@apple.com>
     2
     3        Reviewed by Maciej Stachowiak and Geoff Garen.
     4
     5        Add tests for bug 22287: ASSERTION FAILED: Not enough jumps linked in slow case codegen in CTI::privateCompileSlowCases())
     6        <https://bugs.webkit.org/show_bug.cgi?id=22287>
     7
     8        * fast/js/number-cell-reuse-expected.txt: Added.
     9        * fast/js/number-cell-reuse.html: Added.
     10        * fast/js/resources/number-cell-reuse.js: Added.
     11
    1122008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
    213
Note: See TracChangeset for help on using the changeset viewer.