Changeset 38826 in webkit

Timestamp:

Nov 27, 2008 9:03:46 PM (15 years ago)

Author:

cwzwarich@webkit.org

Message:

2008-11-27 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

r38825 made JSFunction::m_body private, but some inspector code in
WebCore sets the field. Add setters for it, and update the inspector
code to use the new getters and setters.

JavaScriptCore:

• runtime/JSFunction.h: (JSC::JSFunction::setBody):

WebCore:

• inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/JSFunction.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/JavaScriptDebugServer.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-11-27  Cameron Zwarich  <zwarich@apple.com>
+
+        Not reviewed.
+
+        r38825 made JSFunction::m_body private, but some inspector code in
+        WebCore sets the field. Add setters for it.
+
+        * runtime/JSFunction.h:
+        (JSC::JSFunction::setBody):
+
 2008-11-27  Sam Weinig  <sam@webkit.org>
 

trunk/JavaScriptCore/runtime/JSFunction.h

@@ -64 +64 @@
         ScopeChain& scope() { return m_scopeChain; }
 
+        void setBody(FunctionBodyNode* body) { m_body = body; }
+        void setBody(PassRefPtr<FunctionBodyNode> body) { m_body = body; }
         FunctionBodyNode* body() const { return m_body.get(); }
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-11-27  Cameron Zwarich  <zwarich@apple.com>
+
+        Not reviewed.
+
+        r38825, was committed without checking whether anything in WebCore
+        uses JSFunction::m_body. Use the appropriate getters and setters
+        instead.
+
+        * inspector/JavaScriptDebugServer.cpp:
+        (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
+
 2008-11-27  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/inspector/JavaScriptDebugServer.cpp

@@ -563 +563 @@
         JSFunction* function = functions[i];
 
-        FunctionBodyNode* oldBody = function->m_body.get();
+        FunctionBodyNode* oldBody = function->body();
         pair<FunctionBodyMap::iterator, bool> result = functionBodies.add(oldBody, 0);
         if (!result.second) {
-            function->m_body = result.first->second;
+            function->setBody(result.first->second.get());
             continue;
         }
@@ -578 +578 @@
 
         result.first->second = newBody;
-        function->m_body = newBody.release();
+        function->setBody(newBody.release());
 
         if (hasListeners()) {