Changeset 38878 in webkit


Ignore:
Timestamp:
Dec 1, 2008 3:07:04 PM (15 years ago)
Author:
jchaffraix@webkit.org
Message:

2008-12-01 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Antti Koivisto.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
​https://bugs.webkit.org/show_bug.cgi?id=22441

Add an assertion to the modified HTML elements' constructor
to check that the QualifiedName parameter is the one that
matches the Element's.

  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement):
  • html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement):
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement):
  • html/HTMLDListElement.cpp: (WebCore::HTMLDListElement::HTMLDListElement):
  • html/HTMLDirectoryElement.cpp: (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::HTMLDivElement):
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::HTMLHeadElement):
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement):
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::HTMLLIElement):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::HTMLLabelElement):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement):
  • html/HTMLMenuElement.cpp: (WebCore::HTMLMenuElement::HTMLMenuElement):
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::HTMLMetaElement):
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::HTMLOListElement):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::HTMLTitleElement):
  • html/HTMLUListElement.cpp: (WebCore::HTMLUListElement::HTMLUListElement):
Location:
trunk/WebCore
Files:
32 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r38876 r38878  
     12008-12-01  Julien Chaffraix  <jchaffraix@webkit.org>
     2
     3        Reviewed by Antti Koivisto.
     4
     5        Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
     6        https://bugs.webkit.org/show_bug.cgi?id=22441
     7
     8        Add an assertion to the modified HTML elements' constructor
     9        to check that the QualifiedName parameter is the one that
     10        matches the Element's.
     11
     12        * html/HTMLBaseElement.cpp:
     13        (WebCore::HTMLBaseElement::HTMLBaseElement):
     14        * html/HTMLBlockquoteElement.cpp:
     15        (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
     16        * html/HTMLBodyElement.cpp:
     17        (WebCore::HTMLBodyElement::HTMLBodyElement):
     18        * html/HTMLButtonElement.cpp:
     19        (WebCore::HTMLButtonElement::HTMLButtonElement):
     20        * html/HTMLDListElement.cpp:
     21        (WebCore::HTMLDListElement::HTMLDListElement):
     22        * html/HTMLDirectoryElement.cpp:
     23        (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
     24        * html/HTMLDivElement.cpp:
     25        (WebCore::HTMLDivElement::HTMLDivElement):
     26        * html/HTMLFieldSetElement.cpp:
     27        (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
     28        * html/HTMLFormElement.cpp:
     29        (WebCore::HTMLFormElement::HTMLFormElement):
     30        * html/HTMLFrameElement.cpp:
     31        (WebCore::HTMLFrameElement::HTMLFrameElement):
     32        * html/HTMLFrameSetElement.cpp:
     33        (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
     34        * html/HTMLHeadElement.cpp:
     35        (WebCore::HTMLHeadElement::HTMLHeadElement):
     36        * html/HTMLHtmlElement.cpp:
     37        (WebCore::HTMLHtmlElement::HTMLHtmlElement):
     38        * html/HTMLIFrameElement.cpp:
     39        (WebCore::HTMLIFrameElement::HTMLIFrameElement):
     40        * html/HTMLInputElement.cpp:
     41        (WebCore::HTMLInputElement::HTMLInputElement):
     42        * html/HTMLIsIndexElement.cpp:
     43        (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
     44        * html/HTMLKeygenElement.cpp:
     45        (WebCore::HTMLKeygenElement::HTMLKeygenElement):
     46        * html/HTMLLIElement.cpp:
     47        (WebCore::HTMLLIElement::HTMLLIElement):
     48        * html/HTMLLabelElement.cpp:
     49        (WebCore::HTMLLabelElement::HTMLLabelElement):
     50        * html/HTMLLegendElement.cpp:
     51        (WebCore::HTMLLegendElement::HTMLLegendElement):
     52        * html/HTMLLinkElement.cpp:
     53        (WebCore::HTMLLinkElement::HTMLLinkElement):
     54        * html/HTMLMenuElement.cpp:
     55        (WebCore::HTMLMenuElement::HTMLMenuElement):
     56        * html/HTMLMetaElement.cpp:
     57        (WebCore::HTMLMetaElement::HTMLMetaElement):
     58        * html/HTMLOListElement.cpp:
     59        (WebCore::HTMLOListElement::HTMLOListElement):
     60        * html/HTMLOptGroupElement.cpp:
     61        (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
     62        * html/HTMLOptionElement.cpp:
     63        (WebCore::HTMLOptionElement::HTMLOptionElement):
     64        * html/HTMLSelectElement.cpp:
     65        (WebCore::HTMLSelectElement::HTMLSelectElement):
     66        * html/HTMLStyleElement.cpp:
     67        (WebCore::HTMLStyleElement::HTMLStyleElement):
     68        * html/HTMLTextAreaElement.cpp:
     69        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
     70        * html/HTMLTitleElement.cpp:
     71        (WebCore::HTMLTitleElement::HTMLTitleElement):
     72        * html/HTMLUListElement.cpp:
     73        (WebCore::HTMLUListElement::HTMLUListElement):
     74
    1752008-12-01  Chris Marrin  <cmarrin@apple.com>
    276

  • trunk/WebCore/html/HTMLBaseElement.cpp

    r38769 r38878  
    3838    : HTMLElement(qName, doc)
    3939{
     40    ASSERT(hasTagName(baseTag));
    4041}
    4142

  • trunk/WebCore/html/HTMLBlockquoteElement.cpp

    r38791 r38878  
    3232    : HTMLElement(tagName, doc)
    3333{
     34    ASSERT(hasTagName(blockquoteTag));
    3435}
    3536

  • trunk/WebCore/html/HTMLBodyElement.cpp

    r38769 r38878  
    4141using namespace HTMLNames;
    4242
    43 HTMLBodyElement::HTMLBodyElement(const QualifiedName& qName, Document* doc)
    44     : HTMLElement(qName, doc)
    45 {
     43HTMLBodyElement::HTMLBodyElement(const QualifiedName& tagName, Document* doc)
     44    : HTMLElement(tagName, doc)
     45{
     46    ASSERT(hasTagName(bodyTag));
    4647}
    4748

  • trunk/WebCore/html/HTMLButtonElement.cpp

    r38791 r38878  
    4444    , m_activeSubmit(false)
    4545{
     46    ASSERT(hasTagName(buttonTag));
    4647}
    4748

  • trunk/WebCore/html/HTMLDListElement.cpp

    r38791 r38878  
    3131    : HTMLElement(tagName, doc)
    3232{
     33    ASSERT(hasTagName(dlTag));
    3334}
    3435

  • trunk/WebCore/html/HTMLDirectoryElement.cpp

    r38791 r38878  
    3131    : HTMLElement(tagName, doc)
    3232{
     33    ASSERT(hasTagName(dirTag));
    3334}
    3435

  • trunk/WebCore/html/HTMLDivElement.cpp

    r38791 r38878  
    3434    : HTMLElement(tagName, doc)
    3535{
     36    ASSERT(hasTagName(divTag));
    3637}
    3738

  • trunk/WebCore/html/HTMLFieldSetElement.cpp

    r38791 r38878  
    11/*
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    3937   : HTMLFormControlElement(tagName, doc, f)
    4038{
     39    ASSERT(hasTagName(fieldsetTag));
    4140}
    4241

  • trunk/WebCore/html/HTMLFormElement.cpp

    r38791 r38878  
    7878    , m_malformed(false)
    7979{
     80    ASSERT(hasTagName(formTag));
    8081}
    8182

  • trunk/WebCore/html/HTMLFrameElement.cpp

    r38791 r38878  
    11/**
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    4139    , m_frameBorderSet(false)
    4240{
     41    ASSERT(hasTagName(frameTag));
    4342}
    4443

  • trunk/WebCore/html/HTMLFrameSetElement.cpp

    r38791 r38878  
    11/**
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    5553    , noresize(false)
    5654{
     55    ASSERT(hasTagName(framesetTag));
    5756}
    5857

  • trunk/WebCore/html/HTMLHeadElement.cpp

    r38769 r38878  
    11/**
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    3634    : HTMLElement(qName, doc)
    3735{
     36    ASSERT(hasTagName(headTag));
    3837}
    3938

  • trunk/WebCore/html/HTMLHtmlElement.cpp

    r38769 r38878  
    3232using namespace HTMLNames;
    3333
    34 HTMLHtmlElement::HTMLHtmlElement(const QualifiedName& qName, Document* doc)
    35     : HTMLElement(qName, doc)
     34HTMLHtmlElement::HTMLHtmlElement(const QualifiedName& tagName, Document* doc)
     35    : HTMLElement(tagName, doc)
    3636{
     37    ASSERT(hasTagName(htmlTag));
    3738}
    3839

  • trunk/WebCore/html/HTMLIFrameElement.cpp

    r38791 r38878  
    3838    : HTMLFrameElementBase(tagName, doc)
    3939{
     40    ASSERT(hasTagName(iframeTag));
    4041}
    4142

  • trunk/WebCore/html/HTMLInputElement.cpp

    r38791 r38878  
    104104    : HTMLFormControlElementWithState(tagName, doc, f)
    105105{
     106    ASSERT(hasTagName(inputTag) || hasTagName(isindexTag));
    106107    init();
    107108}

  • trunk/WebCore/html/HTMLIsIndexElement.cpp

    r38791 r38878  
    3434    : HTMLInputElement(tagName, doc, f)
    3535{
     36    ASSERT(hasTagName(isindexTag));
    3637    m_name = "isindex";
    3738}

  • trunk/WebCore/html/HTMLKeygenElement.cpp

    r38791 r38878  
    4343    : HTMLSelectElement(tagName, doc, f)
    4444{
     45    ASSERT(hasTagName(keygenTag));
    4546    Vector<String> keys;
    4647    getSupportedKeySizes(keys);

  • trunk/WebCore/html/HTMLLIElement.cpp

    r38791 r38878  
    3737    , m_requestedValue(0)
    3838{
     39    ASSERT(hasTagName(liTag));
    3940}
    4041

  • trunk/WebCore/html/HTMLLabelElement.cpp

    r38791 r38878  
    3939    : HTMLElement(tagName, doc)
    4040{
     41    ASSERT(hasTagName(labelTag));
    4142}
    4243

  • trunk/WebCore/html/HTMLLegendElement.cpp

    r38791 r38878  
    11/*
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    3937    : HTMLFormControlElement(tagName, doc, f)
    4038{
     39    ASSERT(hasTagName(legendTag));
    4140}
    4241

  • trunk/WebCore/html/HTMLLinkElement.cpp

    r38769 r38878  
    5454    , m_createdByParser(false)
    5555{
     56    ASSERT(hasTagName(linkTag));
    5657}
    5758

  • trunk/WebCore/html/HTMLMenuElement.cpp

    r38791 r38878  
    3131    : HTMLElement(tagName, doc)
    3232{
     33    ASSERT(hasTagName(menuTag));
    3334}
    3435

  • trunk/WebCore/html/HTMLMetaElement.cpp

    r38769 r38878  
    11/**
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    3230using namespace HTMLNames;
    3331
    34 HTMLMetaElement::HTMLMetaElement(const QualifiedName& qName, Document* doc)
    35     : HTMLElement(qName, doc)
     32HTMLMetaElement::HTMLMetaElement(const QualifiedName& tagName, Document* doc)
     33    : HTMLElement(tagName, doc)
    3634{
     35    ASSERT(hasTagName(metaTag));
    3736}
    3837

  • trunk/WebCore/html/HTMLOListElement.cpp

    r38791 r38878  
    3535    , m_start(1)
    3636{
     37    ASSERT(hasTagName(olTag));
    3738}
    3839

  • trunk/WebCore/html/HTMLOptGroupElement.cpp

    r38791 r38878  
    4242    , m_style(0)
    4343{
     44    ASSERT(hasTagName(optgroupTag));
    4445}
    4546

  • trunk/WebCore/html/HTMLOptionElement.cpp

    r38791 r38878  
    4646    , m_style(0)
    4747{
     48    ASSERT(hasTagName(optionTag));
    4849}
    4950

  • trunk/WebCore/html/HTMLSelectElement.cpp

    r38791 r38878  
    7777    , m_lastCharTime(0)
    7878{
     79    ASSERT(hasTagName(selectTag) || hasTagName(keygenTag));
    7980}
    8081

  • trunk/WebCore/html/HTMLStyleElement.cpp

    r38791 r38878  
    11/**
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    3836    , m_createdByParser(false)
    3937{
     38    ASSERT(hasTagName(styleTag));
    4039}
    4140

  • trunk/WebCore/html/HTMLTextAreaElement.cpp

    r38791 r38878  
    5656    , m_cachedSelectionEnd(-1)
    5757{
     58    ASSERT(hasTagName(textareaTag));
    5859    setValueMatchesRenderer();
    5960}

  • trunk/WebCore/html/HTMLTitleElement.cpp

    r38791 r38878  
    11/**
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    3735    , m_title("")
    3836{
     37    ASSERT(hasTagName(titleTag));
    3938}
    4039

  • trunk/WebCore/html/HTMLUListElement.cpp

    r38791 r38878  
    3232    : HTMLElement(tagName, doc)
    3333{
     34    ASSERT(hasTagName(ulTag));
    3435}
    3536
Note: See TracChangeset for help on using the changeset viewer.