Changeset 39292 in webkit


Ignore:
Timestamp:
Dec 14, 2008 3:46:36 AM (15 years ago)
Author:
jchaffraix@webkit.org
Message:

2008-12-13 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
​https://bugs.webkit.org/show_bug.cgi?id=22665

Remove setCreatedByParser from frame and iframe.

  • html/HTMLElementFactory.cpp: (WebCore::frameConstructor): (WebCore::iframeConstructor): (WebCore::objectConstructor):
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement):
  • html/HTMLFrameElement.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
  • html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::createdByParser):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • html/HTMLIFrameElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement):
  • html/HTMLTagNames.in:
Location:
trunk/WebCore
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r39289 r39292  
     12008-12-13  Julien Chaffraix  <jchaffraix@webkit.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
     6        https://bugs.webkit.org/show_bug.cgi?id=22665
     7
     8        Remove setCreatedByParser from frame and iframe.
     9
     10        * html/HTMLElementFactory.cpp:
     11        (WebCore::frameConstructor):
     12        (WebCore::iframeConstructor):
     13        (WebCore::objectConstructor):
     14        * html/HTMLFrameElement.cpp:
     15        (WebCore::HTMLFrameElement::HTMLFrameElement):
     16        * html/HTMLFrameElement.h:
     17        * html/HTMLFrameElementBase.cpp:
     18        (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
     19        * html/HTMLFrameElementBase.h:
     20        * html/HTMLFrameOwnerElement.cpp:
     21        (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
     22        * html/HTMLFrameOwnerElement.h:
     23        (WebCore::HTMLFrameOwnerElement::createdByParser):
     24        * html/HTMLIFrameElement.cpp:
     25        (WebCore::HTMLIFrameElement::HTMLIFrameElement):
     26        * html/HTMLIFrameElement.h:
     27        * html/HTMLPlugInElement.cpp:
     28        (WebCore::HTMLPlugInElement::HTMLPlugInElement):
     29        * html/HTMLTagNames.in:
     30
    1312008-12-13  Alexey Proskuryakov  <ap@webkit.org>
    232

  • trunk/WebCore/html/HTMLElementFactory.cpp

    r39180 r39292  
    136136static PassRefPtr<HTMLElement> frameConstructor(const QualifiedName&, Document* doc, HTMLFormElement*, bool createdByParser)
    137137{
    138     RefPtr<HTMLFrameElement> frame = new HTMLFrameElement(frameTag, doc);
    139     frame->setCreatedByParser(createdByParser);
    140     return frame.release();   
     138    return new HTMLFrameElement(frameTag, doc, createdByParser);
    141139}
    142140
    … …  
    148146static PassRefPtr<HTMLElement> iframeConstructor(const QualifiedName&, Document* doc, HTMLFormElement*, bool createdByParser)
    149147{
    150     RefPtr<HTMLIFrameElement> iFrame = new HTMLIFrameElement(iframeTag, doc);
    151     iFrame->setCreatedByParser(createdByParser);
    152     return iFrame.release();   
     148    return new HTMLIFrameElement(iframeTag, doc, createdByParser);
    153149}
    154150
    … …  
    325321static PassRefPtr<HTMLElement> objectConstructor(const QualifiedName&, Document* doc, HTMLFormElement*, bool createdByParser)
    326322{
    327     RefPtr<HTMLObjectElement> object = new HTMLObjectElement(objectTag, doc, createdByParser);
    328     return object.release();
     323    return new HTMLObjectElement(objectTag, doc, createdByParser);
    329324}
    330325

  • trunk/WebCore/html/HTMLFrameElement.cpp

    r38878 r39292  
    3434using namespace HTMLNames;
    3535
    36 HTMLFrameElement::HTMLFrameElement(const QualifiedName& tagName, Document* doc)
    37     : HTMLFrameElementBase(tagName, doc)
     36HTMLFrameElement::HTMLFrameElement(const QualifiedName& tagName, Document* doc, bool createdByParser)
     37    : HTMLFrameElementBase(tagName, doc, createdByParser)
    3838    , m_frameBorder(true)
    3939    , m_frameBorderSet(false)

  • trunk/WebCore/html/HTMLFrameElement.h

    r38791 r39292  
    11/*
    2  * This file is part of the DOM implementation for KDE.
    3  *
    42 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
    53 *           (C) 1999 Antti Koivisto (koivisto@kde.org)
    … …  
    3937{
    4038public:
    41     HTMLFrameElement(const QualifiedName&, Document*);
     39    HTMLFrameElement(const QualifiedName&, Document*, bool createdByParser);
    4240
    4341    virtual HTMLTagStatus endTagRequirement() const { return TagStatusForbidden; }

  • trunk/WebCore/html/HTMLFrameElementBase.cpp

    r38094 r39292  
    4444using namespace HTMLNames;
    4545
    46 HTMLFrameElementBase::HTMLFrameElementBase(const QualifiedName& tagName, Document *doc)
    47     : HTMLFrameOwnerElement(tagName, doc)
     46HTMLFrameElementBase::HTMLFrameElementBase(const QualifiedName& tagName, Document* doc, bool createdByParser)
     47    : HTMLFrameOwnerElement(tagName, doc, createdByParser)
    4848    , m_scrolling(ScrollbarAuto)
    4949    , m_marginWidth(-1)

  • trunk/WebCore/html/HTMLFrameElementBase.h

    r34193 r39292  
    8383
    8484protected:
    85     HTMLFrameElementBase(const QualifiedName&, Document*);
     85    HTMLFrameElementBase(const QualifiedName&, Document*, bool createdByParser);
    8686
    8787    bool isURLAllowed(const AtomicString&) const;

  • trunk/WebCore/html/HTMLFrameOwnerElement.cpp

    r29913 r39292  
    3333namespace WebCore {
    3434
    35 HTMLFrameOwnerElement::HTMLFrameOwnerElement(const QualifiedName& tagName, Document* document)
     35HTMLFrameOwnerElement::HTMLFrameOwnerElement(const QualifiedName& tagName, Document* document, bool createdByParser)
    3636    : HTMLElement(tagName, document)
    3737    , m_contentFrame(0)
    38     , m_createdByParser(false)
     38    , m_createdByParser(createdByParser)
    3939{
    4040}

  • trunk/WebCore/html/HTMLFrameOwnerElement.h

    r29913 r39292  
    3636class HTMLFrameOwnerElement : public HTMLElement {
    3737protected:
    38     HTMLFrameOwnerElement(const QualifiedName& tagName, Document*);
     38    HTMLFrameOwnerElement(const QualifiedName& tagName, Document*, bool createdByParser);
    3939
    4040public:
    … …  
    5151   
    5252    bool createdByParser() const { return m_createdByParser; }
    53     void setCreatedByParser(bool createdByParser) { m_createdByParser = createdByParser; }
    5453
    5554    virtual ScrollbarMode scrollingMode() const { return ScrollbarAuto; }

  • trunk/WebCore/html/HTMLIFrameElement.cpp

    r38878 r39292  
    3535using namespace HTMLNames;
    3636
    37 HTMLIFrameElement::HTMLIFrameElement(const QualifiedName& tagName, Document* doc)
    38     : HTMLFrameElementBase(tagName, doc)
     37HTMLIFrameElement::HTMLIFrameElement(const QualifiedName& tagName, Document* doc, bool createdByParser)
     38    : HTMLFrameElementBase(tagName, doc, createdByParser)
    3939{
    4040    ASSERT(hasTagName(iframeTag));

  • trunk/WebCore/html/HTMLIFrameElement.h

    r38791 r39292  
    3131class HTMLIFrameElement : public HTMLFrameElementBase {
    3232public:
    33     HTMLIFrameElement(const QualifiedName&, Document*);
     33    HTMLIFrameElement(const QualifiedName&, Document*, bool createdByParser);
    3434
    3535    virtual HTMLTagStatus endTagRequirement() const { return TagStatusRequired; }

  • trunk/WebCore/html/HTMLPlugInElement.cpp

    r38774 r39292  
    4646
    4747HTMLPlugInElement::HTMLPlugInElement(const QualifiedName& tagName, Document* doc)
    48     : HTMLFrameOwnerElement(tagName, doc)
     48    // FIXME: Always passing false as createdByParser is odd (see bug22851).
     49    : HTMLFrameOwnerElement(tagName, doc, false)
    4950#if ENABLE(NETSCAPE_PLUGIN_API)
    5051    , m_NPObject(0)

  • trunk/WebCore/html/HTMLTagNames.in

    r39180 r39292  
    4040font
    4141form
    42 frame
     42frame constructorNeedsCreatedByParser=1
    4343frameset interfaceName=HTMLFrameSetElement
    4444head
    … …  
    5252html
    5353i JSInterfaceName=HTMLElement
    54 iframe interfaceName=HTMLIFrameElement
     54iframe interfaceName=HTMLIFrameElement, constructorNeedsCreatedByParser=1
    5555image
    5656img interfaceName=HTMLImageElement
Note: See TracChangeset for help on using the changeset viewer.