Changeset 39443 in webkit

Timestamp:

Dec 22, 2008 4:49:34 PM (15 years ago)

Author:

ddkilzer@apple.com

Message:

Use Deque in CSSStyleSheet::addSubresourceStyleURLs()

Reviewed by Darin Adler.

• css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced use of ListHashSet with more efficient Deque.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSStyleSheet.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-12-22  David Kilzer  <ddkilzer@apple.com>
+
+        Use Deque in CSSStyleSheet::addSubresourceStyleURLs()
+
+        Reviewed by Darin Adler.
+
+        * css/CSSStyleSheet.cpp:
+        (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced
+        use of ListHashSet with more efficient Deque.
+
 2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 

trunk/WebCore/css/CSSStyleSheet.cpp

@@ -30 +30 @@
 #include "Node.h"
 #include "TextEncoding.h"
+#include <wtf/Deque.h>
 
 namespace WebCore {
@@ -213 +214 @@
 void CSSStyleSheet::addSubresourceStyleURLs(ListHashSet<KURL>& urls)
 {
-    typedef ListHashSet<CSSStyleSheet*> CSSStyleSheetList;
-    CSSStyleSheetList styleSheetList;
-    styleSheetList.add(this);
-
-    while (styleSheetList.size() > 0) {
-        CSSStyleSheetList::iterator it = styleSheetList.begin();
-        CSSStyleSheet* styleSheet = *it;
-        styleSheetList.remove(it);
+    Deque<CSSStyleSheet*> styleSheetQueue;
+    styleSheetQueue.append(this);
+
+    while (!styleSheetQueue.isEmpty()) {
+        CSSStyleSheet* styleSheet = styleSheetQueue.first();
+        styleSheetQueue.removeFirst();
 
         RefPtr<CSSRuleList> ruleList = styleSheet->cssRules();
@@ -228 +227 @@
             if (rule->isImportRule()) {
                 if (CSSStyleSheet* ruleStyleSheet = static_cast<CSSImportRule*>(rule)->styleSheet())
-                    styleSheetList.add(ruleStyleSheet);
+                    styleSheetQueue.append(ruleStyleSheet);
             }
             rule->addSubresourceStyleURLs(urls);