Changeset 39445 in webkit

Timestamp:

Dec 22, 2008 5:29:05 PM (15 years ago)

Author:

Nikolas Zimmermann

Message:

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22971

Fix regression caused by the HTMLFormElement refactorization.
File form elements without a name have to be included in multipart/form-data
submission. Cover this behaviour with a new test case.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/empty-file-formdata-expected.txt (added)
• LayoutTests/http/tests/misc/empty-file-formdata.html (added)
• LayoutTests/http/tests/misc/resources/check-unnamed-file-included-in-formdata.php (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLFormElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
+
+        Reviewed by George Staikos.
+
+        Fixes: https://bugs.webkit.org/show_bug.cgi?id=22971
+
+        Fix regression caused by the HTMLFormElement refactorization.
+        File form elements without a name have to be included in multipart/form-data
+        submission. Cover this behaviour with a new test case.
+
+        * http/tests/misc/empty-file-formdata-expected.txt: Added.
+        * http/tests/misc/empty-file-formdata.html: Added.
+        * http/tests/misc/resources/check-unnamed-file-included-in-formdata.php: Added.
+
 2008-12-22  David Kilzer  <ddkilzer@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
+
+        Reviewed by George Staikos.
+
+        Fixes: https://bugs.webkit.org/show_bug.cgi?id=22971
+
+        Fix regression caused by the HTMLFormElement refactorization.
+        File form elements without a name have to be included in multipart/form-data
+        submission. Cover this behaviour with a new test case.
+
+        Test: http/tests/misc/empty-file-formdata.html
+
+        * html/HTMLFormElement.cpp:
+        (WebCore::HTMLFormElement::createFormData):
+        * wml/WMLTagNames.in:
+
 2008-12-22  David Kilzer  <ddkilzer@apple.com>
 

trunk/WebCore/html/HTMLFormElement.cpp

@@ -208 +208 @@
                         }
 
+                        // We have to include the filename=".." part in the header, even if the filename is empty
+                        // Covered by LayoutTests/http/tests/misc/empty-file-formdata.html
+                        m_formDataBuilder.addFilenameToMultiPartHeader(header, encoding, fileName);
+
                         if (!fileName.isEmpty()) {
-                            m_formDataBuilder.addFilenameToMultiPartHeader(header, encoding, fileName);
-
                             // FIXME: The MIMETypeRegistry function's name makes it sound like it takes a path,
                             // not just a basename. But filename is not the path. But note that it's not safe to