Changeset 39462 in webkit

Timestamp:

Dec 23, 2008 9:19:54 PM (15 years ago)

Author:

Simon Fraser

Message:

2008-12-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=21910

Fix SVGImage painting by ensuring that the SVGImage resizes its FrameView correctly.
Otherwise the FrameView is left at 0x0, and nothing paints.

• svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-1-expected.png (modified) (previous)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-2-expected.png (modified) (previous)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-3-expected.png (modified) (previous)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-4-expected.png (modified) (previous)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.png (modified) (previous)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-mask-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/backgrounds/svg-as-mask-expected.png (modified) (previous)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-image-05-b-expected.png (modified) (previous)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/graphics/SVGImage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-12-23  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dan Bernstein
+
+        https://bugs.webkit.org/show_bug.cgi?id=21910
+        
+        Re-create expected images after fixing painting issue with SVGImage.
+
+        * platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum:
+        * platform/mac/fast/backgrounds/svg-as-background-1-expected.png:
+        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum:
+        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png:
+        * platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
+        * platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
+        * platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
+        * platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
+        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
+        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
+        * platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
+        * platform/mac/fast/backgrounds/svg-as-mask-expected.png:
+        * platform/mac/svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
+        * platform/mac/svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
+
 2008-12-22  Julien Chaffraix  <jchaffraix@webkit.org>
 

trunk/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum

@@ -1 @@
-dfb9aa4f0d4de9ea10677a910750cc75
+e49ee337e545a30910d9a02a694ff4cd

trunk/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum

@@ -1 @@
-dfb9aa4f0d4de9ea10677a910750cc75
+a75ed15518d93a7e085a4bf04c432f70

trunk/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum

@@ -1 @@
-dfb9aa4f0d4de9ea10677a910750cc75
+0051e7416b386384a60e61195bc1bd68

trunk/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum

@@ -1 @@
-dfb9aa4f0d4de9ea10677a910750cc75
+088975309527826bb61f29423595a137

trunk/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum

@@ -1 @@
-dfb9aa4f0d4de9ea10677a910750cc75
+d4e84d86c15d0348f7c1a82dcee6aae3

trunk/LayoutTests/platform/mac/fast/backgrounds/svg-as-mask-expected.checksum

@@ -1 @@
-853de00567d121bea0b7bece66a5d61c
+d87598d28e8dc6fd730c60473c682e79

trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum

@@ -1 @@
-0b3b87974f2497891e96be2a27da6cd2
+d7f063609a1cce788f0df1fb824f4133

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-12-23  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dan Bernstein
+
+        https://bugs.webkit.org/show_bug.cgi?id=21910
+        
+        Fix SVGImage painting by ensuring that the SVGImage resizes its FrameView correctly.
+        Otherwise the FrameView is left at 0x0, and nothing paints.
+        
+        * svg/graphics/SVGImage.cpp:
+        (WebCore::SVGImage::draw):
+
 2008-12-23  Darin Adler  <darin@apple.com>
 

trunk/WebCore/svg/graphics/SVGImage.cpp

@@ -151 +151 @@
     context->translate(dstRect.location().x(), dstRect.location().y());
     context->scale(FloatSize(dstRect.width()/srcRect.width(), dstRect.height()/srcRect.height()));
-    
+
+    m_frame->view()->resize(size());
+
     if (m_frame->view()->needsLayout())
         m_frame->view()->layout();