Changeset 39463 in webkit


Ignore:
Timestamp:
Dec 23, 2008 9:23:36 PM (15 years ago)
Author:
Simon Fraser
Message:

2008-12-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=22941

If the document element has opacity, we need to erase the view background to
white before painting.

Test: fast/backgrounds/opacity-on-document-element.html

  • rendering/RenderView.cpp: (WebCore::rendererObscuresBackground):
Location:
trunk
Files:
4 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r39462 r39463  
     12008-12-23  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Reviewed by Dan Bernstein
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=22941
     6       
     7        Add test for opacity on the document element.
     8
     9        * fast/backgrounds/opacity-on-document-element.html: Added.
     10        * platform/mac/fast/backgrounds/opacity-on-document-element-expected.checksum: Added.
     11        * platform/mac/fast/backgrounds/opacity-on-document-element-expected.png: Added.
     12        * platform/mac/fast/backgrounds/opacity-on-document-element-expected.txt: Added.
     13       
     14        * fast/transforms/identity-matrix.html:
     15        * platform/mac/fast/transforms/identity-matrix-expected.txt:
     16        Fix typo
     17
    1182008-12-23  Simon Fraser  <simon.fraser@apple.com>
    219

  • trunk/LayoutTests/fast/transforms/identity-matrix.html

    r27649 r39463  
    1313</head>
    1414<body>
    15 The following divs should be idential:
     15The following divs should be identical:
    1616    <br>
    1717

  • trunk/LayoutTests/platform/mac/fast/transforms/identity-matrix-expected.txt

    r30635 r39463  
    44  RenderBlock {HTML} at (0,0) size 800x600
    55    RenderBody {BODY} at (8,8) size 784x584
    6       RenderText {#text} at (0,0) size 243x18
    7         text run at (0,0) width 243: "The following divs should be idential: "
     6      RenderText {#text} at (0,0) size 250x18
     7        text run at (0,0) width 250: "The following divs should be identical: "
    88      RenderBR {BR} at (0,0) size 0x0
    99      RenderBlock (floating) {DIV} at (5,23) size 110x110 [bgcolor=#87CEEB] [border: (5px solid #000000)]

  • trunk/WebCore/ChangeLog

    r39462 r39463  
     12008-12-23  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Reviewed by Dan Bernstein
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=22941
     6       
     7        If the document element has opacity, we need to erase the view background to
     8        white before painting.
     9       
     10        Test: fast/backgrounds/opacity-on-document-element.html
     11
     12        * rendering/RenderView.cpp:
     13        (WebCore::rendererObscuresBackground):
     14
    1152008-12-23  Simon Fraser  <simon.fraser@apple.com>
    216

  • trunk/WebCore/rendering/RenderView.cpp

    r39413 r39463  
    172172static inline bool rendererObscuresBackground(RenderObject* object)
    173173{
    174     // FIXME: this should test opacity too.
    175     return object && object->style()->visibility() == VISIBLE && !object->style()->hasTransform();
     174    return object && object->style()->visibility() == VISIBLE && object->style()->opacity() == 1 && !object->style()->hasTransform();
    176175}
    177176   
Note: See TracChangeset for help on using the changeset viewer.