Changeset 39588 in webkit

Timestamp:

Jan 4, 2009 10:38:35 AM (15 years ago)

Author:

Simon Fraser

Message:

2009-01-04 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=23090

If an object gets a Layout hint, and the style change will result in
the creation of a RenderLayer, then we need to repaint the old position
of the object. This was done for transform, but we have to test opacity too.

Test: fast/repaint/create-layer-repaint.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/create-layer-repaint.html (added)
• LayoutTests/platform/mac/fast/repaint/create-layer-repaint-expected.checksum (added)
• LayoutTests/platform/mac/fast/repaint/create-layer-repaint-expected.png (added)
• LayoutTests/platform/mac/fast/repaint/create-layer-repaint-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-01-04  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Darin Adler
+
+        https://bugs.webkit.org/show_bug.cgi?id=23090
+        
+        Repaint test for repainting when an element gets smaller,
+        and gains a RenderLayer at the same time.
+        
+        * fast/repaint/create-layer-repaint.html: Added.
+        * platform/mac/fast/repaint/create-layer-repaint-expected.checksum: Added.
+        * platform/mac/fast/repaint/create-layer-repaint-expected.png: Added.
+        * platform/mac/fast/repaint/create-layer-repaint-expected.txt: Added.
+
 2009-01-02  Adam Treat  <treat@kde.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-01-04  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Darin Adler
+
+        https://bugs.webkit.org/show_bug.cgi?id=23090
+        
+        If an object gets a Layout hint, and the style change will result in
+        the creation of a RenderLayer, then we need to repaint the old position
+        of the object. This was done for transform, but we have to test opacity too.
+
+        Test: fast/repaint/create-layer-repaint.html
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::styleWillChange):
+
 2009-01-04  Darin Adler  <darin@apple.com>
 

trunk/WebCore/rendering/RenderObject.cpp

@@ -2304 +2304 @@
                     m_style->transform() != newStyle->transform())
                 layer()->repaintIncludingDescendants();
-            } else if (m_style->transform() != newStyle->transform()) {
-                // If we don't have a layer yet, but we are going to get one because of a transform change, then
-                // we need to repaint the old position of the object
+            } else if (newStyle->hasTransform() || newStyle->opacity() < 1) {
+                // If we don't have a layer yet, but we are going to get one because of transform or opacity,
+                //  then we need to repaint the old position of the object.
                 repaint();
             }