Changeset 39848 in webkit

Timestamp:

Jan 12, 2009 4:22:54 PM (15 years ago)

Author:

bfulgham@webkit.org

Message:

Correct scrolldelay units (s -> ms)

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/webkit-marquee-speed-unit-in-quirksmode-expected.txt (added)
• LayoutTests/fast/css/webkit-marquee-speed-unit-in-quirksmode.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSParser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2009-01-12  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by Darin Adler
+        
+        Fix for <https://bugs.webkit.org/show_bug.cgi?id=22096>
+        Bug 22096: REGRESSION (r35879) scrolldelay is counted in seconds 
+        instead of miliseconds
+
+        * fast/css/webkit-marquee-speed-unit-in-quirksmode-expected.txt: Added.
+        * fast/css/webkit-marquee-speed-unit-in-quirksmode.html: Added.
+
 2009-01-12  Eric Roman  <eroman@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-01-12  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by Darin Adler
+
+        Fix for <https://bugs.webkit.org/show_bug.cgi?id=22096>
+        Bug 22096: REGRESSION (r35879) scrolldelay is counted in seconds 
+        instead of miliseconds
+
+        Test: fast/css/webkit-marquee-speed-unit-in-quirksmode.html
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::validUnit): treat unitless values in quirks mode 
+        as miliseconds instead of seconds.
+
 2009-01-12  David Hyatt  <hyatt@apple.com>
 

trunk/WebCore/css/CSSParser.cpp

@@ -412 +412 @@
         if (!b && ((unitflags & (FLength | FAngle | FTime)) && (value->fValue == 0 || !strict))) {
             value->unit = (unitflags & FLength) ? CSSPrimitiveValue::CSS_PX :
-                          ((unitflags & FAngle) ? CSSPrimitiveValue::CSS_DEG : CSSPrimitiveValue::CSS_S);
+                          ((unitflags & FAngle) ? CSSPrimitiveValue::CSS_DEG : CSSPrimitiveValue::CSS_MS);
             b = true;
         }