Changeset 40160 in webkit

Timestamp:

Jan 23, 2009 7:02:38 AM (15 years ago)

Author:

treat@webkit.org

Message:

Redo previous patch ​http://trac.webkit.org/changeset/34260 which fixes a
huge memory leak by ensuring that the timer is fired one last time on
application tear down thus triggering the GCController thereby freeing
JavaScript objects as well as triggering other timer based tear down methods.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/SharedTimerQt.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2009-01-23  Adam Treat  <adam.treat@torchmobile.com>
+
+        Reviewed by Holger Hans Peter Freyther.
+
+        Redo previous patch http://trac.webkit.org/changeset/34260 which fixes a
+        huge memory leak by ensuring that the timer is fired one last time on
+        application tear down thus triggering the GCController thereby freeing
+        JavaScript objects as well as triggering other timer based tear down methods.
+
+        * platform/qt/SharedTimerQt.cpp:
+        (WebCore::SharedTimerQt::~SharedTimerQt):
+
 2009-01-23  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/platform/qt/SharedTimerQt.cpp

@@ -53 +53 @@
 private:
     SharedTimerQt(QObject* parent);
+    ~SharedTimerQt();
     QBasicTimer m_timer;
     void (*m_timerFunction)();
@@ -61 +62 @@
     , m_timerFunction(0)
 {}
+
+SharedTimerQt::~SharedTimerQt()
+{
+    if (m_timer.isActive())
+        (m_timerFunction)();
+}
 
 SharedTimerQt* SharedTimerQt::inst()