Changeset 41017 in webkit


Ignore:
Timestamp:
Feb 14, 2009 8:39:31 AM (15 years ago)
Author:
Dimitri Glazkov
Message:

2009-02-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23955
V8HTMLPlugInCustom returns undefined, which fools interceptors.

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value. (WebCore::NAMED_PROPERTY_SETTER): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Ditto. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r41016 r41017  
     12009-02-13  Dimitri Glazkov  <dglazkov@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=23955
     6        V8HTMLPlugInCustom returns undefined, which fools interceptors.
     7
     8        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
     9        (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value.
     10        (WebCore::NAMED_PROPERTY_SETTER): Ditto.
     11        (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
     12        (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
     13
    1142009-02-13  Dimitri Glazkov  <dglazkov@chromium.org>
    215
  • trunk/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp

    r40911 r41017  
    4949    ScriptInstance scriptInstance = imp->getInstance();
    5050    if (!scriptInstance)
    51         return v8::Undefined();
     51        return deferToInterceptor();
    5252
    5353    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    5454    if (instance.IsEmpty())
    55         return v8::Undefined();
     55        return deferToInterceptor();
    5656
    5757    return NPObjectGetNamedProperty(instance, name);
     
    6464    ScriptInstance scriptInstance = imp->getInstance();
    6565    if (!scriptInstance)
    66         return v8::Undefined();
     66        return deferToInterceptor();
    6767
    6868    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    6969    if (instance.IsEmpty())
    70         return v8::Undefined();
     70        return deferToInterceptor();
    7171
    7272    return NPObjectSetNamedProperty(instance, name, value);
     
    8585    ScriptInstance scriptInstance = imp->getInstance();
    8686    if (!scriptInstance)
    87         return v8::Undefined();
     87        return deferToInterceptor();
    8888
    8989    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    9090    if (instance.IsEmpty())
    91         return v8::Undefined();
     91        return deferToInterceptor();
    9292
    9393    return NPObjectGetIndexedProperty(instance, index);
     
    100100    ScriptInstance scriptInstance = imp->getInstance();
    101101    if (!scriptInstance)
    102         return v8::Undefined();
     102        return deferToInterceptor();
    103103
    104104    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    105105    if (instance.IsEmpty())
    106         return v8::Undefined();
     106        return deferToInterceptor();
    107107
    108108    return NPObjectSetIndexedProperty(instance, index, value);
Note: See TracChangeset for help on using the changeset viewer.